Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Document list] Cannot remove a widget which is a list item #11346

Closed
FilipTokarski opened this issue Feb 28, 2022 · 4 comments · Fixed by #11527
Closed

[Document list] Cannot remove a widget which is a list item #11346

FilipTokarski opened this issue Feb 28, 2022 · 4 comments · Fixed by #11527
Assignees
@arkflpc
Labels
package:list squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 52 (v34...

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

  1. Switch to ck/10812-document-list-editing
  2. Create a list with a few list items and a table as one of the list items
  3. Select the table
  4. Press backspace

✔️ Expected result

Table is deleted, there is an empty list item.

❌ Actual result

Table is not deleted. The list item after the one with the table gets deleted.

Screencast

0_list1.mp4

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:list squad:core Issue to be handled by the Core team. labels Feb 28, 2022
@FilipTokarski FilipTokarski mentioned this issue Feb 28, 2022
Closed
@Reinmar
Copy link
Member

Reinmar commented Mar 2, 2022

The editor does not differentiate these two situations:

And this one:

@Reinmar
Copy link
Member

Reinmar commented Mar 2, 2022 •
edited
Loading

Expected behavior: When the table is selected, the table should be removed.

Note: both: forward and backward delete should have the same behavior (deleting a table).

Possible future improvements:

  • If we have a fake caret before a widget, then on backspace, the current item (the one with the table inside) should be merged to the preceding item (2). This deserves a followup but definitely should not be part of this ticket.

@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Mar 14, 2022
@Reinmar
Copy link
Member

Reinmar commented Mar 14, 2022

The question that we have: this event is a bubbling one, so the handler for the widget removal should be called first. Is it? If not – why? If yes - wth?

@arkflpc arkflpc self-assigned this Mar 18, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Mar 18, 2022
@Reinmar Reinmar changed the title Cannot remove a widget which is a list item [Document list] Cannot remove a widget which is a list item Mar 28, 2022
@arkflpc arkflpc mentioned this issue Mar 29, 2022
Merged
@CatStrategist CatStrategist mentioned this issue Mar 30, 2022
Closed
@oleq oleq mentioned this issue Apr 1, 2022
Closed
oleq added a commit that referenced this issue Apr 1, 2022
@oleq
Merge pull request #11527 from ckeditor/ck/11346-fix-deleting-widget-…
38f0c8b 
…list-item

Internal (list): Deleting a widget which is a document list item should be possible. Closes #11346.
@oleq
Copy link
Member

oleq commented Apr 1, 2022

Closed in #11527.

@oleq oleq closed this as completed Apr 1, 2022
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 1, 2022
@CKEditorBot CKEditorBot added this to the upcoming milestone Apr 1, 2022
oleq added a commit that referenced this issue Apr 4, 2022
@oleq
Merge pull request #11503 from ckeditor/ck/epic/2973-document-lists
b53d2a4 
Feature (list): Introducing the document (advanced) list feature (multiple blocks per list item). Closes #2973. Closes #10812.

Feature (list): Introducing the document (advanced) list properties feature (list styles, start index, reversed list). Closes #11065.

Feature (html-support): Adds support for document list in the `GeneralHtmlSupport` feature. Closes #11454. Closes #11359. Closes #11358.

Feature (engine): Added a new `Model#insertObject()` method for inserting elements defined as objects by model schema (see #11198).

Feature (engine): Introduced inheritable `$container`, `$blockObject`, and `$inlineObject` element types in the model `Schema` (see #11197).

Feature (engine): Introduced `TabObserver` that allows listening to pressing down the `Tab` key in a specified context.

Feature (paragraph): Added an optional `options.attributes` parameter to the `InsertParagraph` command that allows setting attributes on a created paragraph (see #11198).

Feature (core): `MultiCommand` now allows setting a priority (order) of registered sub commands. Closes #11083.

Feature (engine): Added a new `Schema#getAttributesWithProperty()` method that retrieves attributes from a node which have given property (see #11198).

Feature (engine): Added a new `Schema#setAllowedAttributes()` method that validates whether attributes are allowed on a given element before setting them (see #11198).

Other (engine): The `Differ` change entries for `insert` and `remove` types are extended with a map of attributes that were set while inserting an element or that belonged to an element that got removed.

Other (engine): The `DowncastHelpers` are passing an additional parameter to the creator functions (the `data` that provides more context to the element creator callback).

Other (engine): The `isAllowedInsideAttributeElement` option was removed, from now on `AttributeElements` are allowed to wrap any view element.

Other (engine): The `ConversionApi` provided by the `UpcastDispatcher` was extended by an additional `keepEmptyElement()` method that marks an element that was created during splitting a model element that should not get removed on conversion even if it is empty. 

Other (html-support): Updated default schema definitions for various elements taking advantage of the `$container`, `$blockObject`, and `$inlineObject` elements in model schema (see #11197).

Other (table, code-block, list): The handling of `Tab` and `Shift+Tab` keystrokes switched to the `'tab'` view document event and now respects the event context.

Other (media-embed): Added an optional `findOptimalPosition` parameter to the `insertMedia()` helper that allows for inserting `media` model element without breaking the content (see #11198).

Fix (link): The link decorators should be converted on block images only once (should not wrap block image with an additional link).

Internal (engine): Added option for the `DomConverter` to transparently render only the content of the element in the data pipeline.

Internal (engine): Added option for the `DomConverter` to transparently render only the content of the element in the data pipeline.

Internal (engine): The `findOptimalPosition()` helper is now available in the ckeditor5-engine package for internal use (see #11198).

Internal (list): `DocumentListEditing` should extend `$container` (for `blockQuote`, etc.), `$block` (for `paragraph`, `heading2`, etc.), and `$blockObject` (for `table`, `horizontalLine`, etc.) with its attributes. Closes #11197.

Internal (list): `indentList` and `outdentList` commands are now registered with priority in 'Indent' `MultiCommand` , `Tab` and `Tab+Shift` listeners now executes in `li` context in order to not interfere with other plugins' listeners . Closes #11072.

Internal (list): Adds `DocumentListStartCommand` and `DocumentListReversedCommand`. Closes #11166.

Internal (list): Adds `DocumentListStyleCommand`. See #11166.

Internal (list): Adds post-fixer that makes sure that all items in a single list have the same start, reversed, and style properties. Closes #11167.

Internal (list): Deleting a widget which is a document list item should be possible. Closes #11346.

Internal (list): Document list items should not get split by inserting block objects (widgets). Closes #11198.

Internal (list): Implemented backspace and delete handling in and around document lists. Closes #10878.

Internal (list): Implemented handling of `Tab` and `Tab+Shift` keys in document lists. Closes #10880.

Internal (list): Implemented the `DocumentListMergeCommand`. Closes #10977.

Internal (list): Improved enter handling in document lists by allowing to split the list item when the collapsed selection is anchored in the first (but not only) empty block of a list item (see #10879, #10976).

Internal (list): Integrated the enter feature with document lists. Closes #10879. Closes #10976.

Internal (list): Reset document list properties after indent. Closes #11357.

Internal (table, page-break, horizontal-line, media-embed, html-embed, image): `table`, `pageBreak`, `horizontalLine`, `media`, `imageBlock`,`imageInline` elements are now inserted with `insertObject()` function instead of `insertContent()` (see #11198).

Internal (list): Added `DocumentListCommand` and `DocumentListIndentCommand`. Closes #10974. Closes #10975.

MINOR BREAKING CHANGE (html-support): The `$htmlSection`, `$htmlObjectBlock`, and `$htmlObjectInline` element types are no longer available for custom elements registered via `registerBlockElement()` to inherit from. Please use `$container`, `$blockObject`, and `$inlineObject` instead (see #11197).

MINOR BREAKING CHANGE (engine): The `isAllowedInsideAttributeElement` option was removed so `AttributeElements` can wrap any view element (according to positions). Make sure that you are not wrapping any `ContainerElement` by an accident by not checking the target in the converter. Those would previously get wrapped by an `AttributeElement` that immediately would be removed by the `ContainerElement` within it so there would not be any visual effect.

MINOR BREAKING CHANGE (engine): The handling of `Tab` and `Shift+Tab` keystrokes switched to the `'tab'` view document event across the project. If your integration uses `KeystrokeHandler` for `Tab` key handling, we recommend you migrate to the `'tab'` event to avoid unpredicted errors.

MINOR BREAKING CHANGE (engine): If your integration uses `Model#insertContent()` and `findOptimalInsertionRange()` to insert widgets into the content, we recommend you migrate your code to `Model#insertObject()` for best results. This is particularly relevant for compatibility with the document (advanced) lists feature (see #11198).
@Reinmar Reinmar modified the milestones: upcoming, iteration 52 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
package:list squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 52 (v34.0.0)
Development

Successfully merging a pull request may close this issue.

Ck/11346 fix deleting widget list item ckeditor/ckeditor5
5 participants
@Reinmar @oleq @arkflpc @CKEditorBot @FilipTokarski