Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for plain table + caption in the data pipeline #11240

Merged
merged 25 commits into from
Mar 2, 2022
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6741001
Table with caption but without figure POC.
dawidurbanski Feb 8, 2022
d60b03f
Rename the plugin.
dawidurbanski Feb 10, 2022
3e150be
Rename the plugin.
dawidurbanski Feb 10, 2022
19ebbb2
Remove GHS from manual test.
dawidurbanski Feb 11, 2022
093b970
Add tests to TableCaptionUI.
dawidurbanski Feb 14, 2022
eb5fb2b
Remove redundant TableUtils dependency.
dawidurbanski Feb 14, 2022
7991556
Remove redundant TableUtils dependency from tests.
dawidurbanski Feb 14, 2022
e049e0b
Tests for table border attributes.
dawidurbanski Feb 14, 2022
445516e
Small refactoring. Add dockblocks and comments.
dawidurbanski Feb 14, 2022
719e989
Add tests for tableAlignment attribute.
dawidurbanski Feb 14, 2022
a67b025
Add tests for table width and height attributes.
dawidurbanski Feb 14, 2022
aaa109a
Add background color attribute support.
dawidurbanski Feb 14, 2022
220ebb9
Default table properties.
dawidurbanski Feb 14, 2022
bb44ac9
Cleanup.
dawidurbanski Feb 14, 2022
e48ad38
Update test desctipion.
dawidurbanski Feb 23, 2022
185b9d8
Remove unnecessary required plugins.
dawidurbanski Feb 24, 2022
89994b7
Remove unnecessary attribute reconversion from downcast converter.
dawidurbanski Feb 24, 2022
abfde3c
Make sure plain output plugin works without table caption or table pr…
dawidurbanski Feb 24, 2022
f98986c
Make TableCaption converter optional. Fix memory leaks in tests.
dawidurbanski Feb 25, 2022
754de50
Convert only table captions.
dawidurbanski Feb 25, 2022
83e6cec
Change model element name.
dawidurbanski Feb 25, 2022
bb5eda5
Fix warning in automatic tests.
dawidurbanski Feb 25, 2022
13ccbb0
Add thead and tbody to the plain table output if heading rows detected.
dawidurbanski Feb 25, 2022
2179c4b
Improved the error description.
Reinmar Mar 2, 2022
11dc8cf
Removed unnecessary styling, added missing image toolbar config, adde…
Reinmar Mar 2, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/ckeditor5-widget/src/widgettoolbarrepository.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,18 @@ export default class WidgetToolbarRepository extends Plugin {
// Trying to register a toolbar without any item.
if ( !items.length ) {
/**
* When {@link #register} a new toolbar, you need to provide a non-empty array with
* When {@link #register registering} a new widget toolbar, you need to provide a non-empty array with
* the items that will be inserted into the toolbar.
*
* If you see this error when integrating the editor, you likely forgot to configure one of the widget toolbars.
*
* See for instance:
*
* * {@link module:table/table~TableConfig#contentToolbar `editor.config.table.contentToolbar`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be config.table.contentToolbar. I will fix this on master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

69db658 done

* * {@link module:image/image~ImageConfig#toolbar `editor.config.image.toolbar`}
*
* @error widget-toolbar-no-items
* @param {String} toolbarId The id of the toolbar that has not been configured correctly.
*/
logWarning( 'widget-toolbar-no-items', { toolbarId } );

Expand Down