-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for plain table + caption in the data pipeline #11240
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6741001
Table with caption but without figure POC.
dawidurbanski d60b03f
Rename the plugin.
dawidurbanski 3e150be
Rename the plugin.
dawidurbanski 19ebbb2
Remove GHS from manual test.
dawidurbanski 093b970
Add tests to TableCaptionUI.
dawidurbanski eb5fb2b
Remove redundant TableUtils dependency.
dawidurbanski 7991556
Remove redundant TableUtils dependency from tests.
dawidurbanski e049e0b
Tests for table border attributes.
dawidurbanski 445516e
Small refactoring. Add dockblocks and comments.
dawidurbanski 719e989
Add tests for tableAlignment attribute.
dawidurbanski a67b025
Add tests for table width and height attributes.
dawidurbanski aaa109a
Add background color attribute support.
dawidurbanski 220ebb9
Default table properties.
dawidurbanski bb44ac9
Cleanup.
dawidurbanski e48ad38
Update test desctipion.
dawidurbanski 185b9d8
Remove unnecessary required plugins.
dawidurbanski 89994b7
Remove unnecessary attribute reconversion from downcast converter.
dawidurbanski abfde3c
Make sure plain output plugin works without table caption or table pr…
dawidurbanski f98986c
Make TableCaption converter optional. Fix memory leaks in tests.
dawidurbanski 754de50
Convert only table captions.
dawidurbanski 83e6cec
Change model element name.
dawidurbanski bb5eda5
Fix warning in automatic tests.
dawidurbanski 13ccbb0
Add thead and tbody to the plain table output if heading rows detected.
dawidurbanski 2179c4b
Improved the error description.
Reinmar 11dc8cf
Removed unnecessary styling, added missing image toolbar config, adde…
Reinmar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be
config.table.contentToolbar
. I will fix this on master.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
69db658 done