Support for plain table + caption in the data pipeline #11240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidurbanski
changed the title
niegowski
reviewed
Feb 24, 2022
niegowski
reviewed
Feb 24, 2022
niegowski
reviewed
Feb 24, 2022
|
I played with the feature a bit and to me, it looks good in terms of functionality. However, I found some issues that require followups.
|
Reinmar
force-pushed
the
ck/10892-table-caption
branch
from
29c3268
to
11dc8cf
Compare
|
Ooops. I mistakenly rebased the entire branch when fixing one of my commits:facepalm: Sorry for the future readers of this PR. |
Reinmar
reviewed
Mar 2, 2022
| * | ||
| * See for instance: | ||
| * | ||
| * * {@link module:table/table~TableConfig#contentToolbar `editor.config.table.contentToolbar`} |
There was a problem hiding this comment.
It should be config.table.contentToolbar. I will fix this on master.
This was referenced Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (table): Introduced the
PlainTableOutputplugin to override defaultfigure>captionmarkup in the data pipeline. Closes: #10892.Tests (table): Added tests for the
TableCaptionUIplugin.Please note that as per the original ticket we don't document this feature in any guides.