-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for plain table + caption in the data pipeline #11240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, clean work! 🎉
I played with the feature a bit and to me, it looks good in terms of functionality. However, I found some issues that require followups.
|
29c3268
to
11dc8cf
Compare
Ooops. I mistakenly rebased the entire branch when fixing one of my commits:facepalm: Sorry for the future readers of this PR. |
* | ||
* See for instance: | ||
* | ||
* * {@link module:table/table~TableConfig#contentToolbar `editor.config.table.contentToolbar`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be config.table.contentToolbar
. I will fix this on master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
69db658 done
Suggested merge commit message (convention)
Feature (table): Introduced the
PlainTableOutput
plugin to override defaultfigure>caption
markup in the data pipeline. Closes: #10892.Tests (table): Added tests for the
TableCaptionUI
plugin.Please note that as per the original ticket we don't document this feature in any guides.