Ck/10146 find in multiroot #10200
Merged
Ck/10146 find in multiroot #10200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
reviewed
Jul 27, 2021
| @@ -88,7 +88,7 @@ export default class FindAndReplaceUI extends Plugin { | |||
| this.formView = formView; | |||
|
|
|||
| editor.keystrokes.set( 'Ctrl+F', ( data, cancelEvent ) => { | |||
| dropdown.buttonView.actionView.fire( 'execute' ); | |||
There was a problem hiding this comment.
This has been fixed couple of days ago #10189 I'll merge the latest master branch.
mlewand
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (find-and-replace): Find and replace feature should work in the multi-root editor. Closes #10146.
Fix (find-and-replace): The
Ctrl+Fshortcut should open the find and replace drop-down.Tests (find-and-replace): Added automatic and manual tests for the find and replace feature in the multi-root editor. See #10146.
Docs: Added the find and replace feature to the multi-root editor example.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.