Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find and replace multiroot support #10146

Closed
mlewand opened this issue Jul 13, 2021 · 1 comment · Fixed by #10200
Closed

Find and replace multiroot support #10146

mlewand opened this issue Jul 13, 2021 · 1 comment · Fixed by #10200
Assignees
@magda-chrzescian
Labels
package:find-and-replace squad:core Issue to be handled by the Core team. squad:features Issue to be handled by the Features team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 45 (v29...

Comments

@mlewand
Copy link
Contributor

mlewand commented Jul 13, 2021

📝 Provide detailed reproduction steps (if any)

The find and replace feature should support editor with multiple document roots.

Surely we'd have to ignore special roots (that starting with the $ sign).

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. squad:features Issue to be handled by the Features team. package:find-and-replace support:2 An issue reported by a commercially licensed client. labels Jul 13, 2021
@108signals
Copy link

This feature would be very helpful for our users who have large, quasi-legal documents in the hundreds of pages. We use the multi root editor to create a seamless experience. Currently they use the browser for finding content which is not a good workaround.

@magda-chrzescian magda-chrzescian self-assigned this Jul 20, 2021
@magda-chrzescian magda-chrzescian added this to the iteration 45 milestone Jul 20, 2021
@magda-chrzescian magda-chrzescian added the squad:core Issue to be handled by the Core team. label Jul 20, 2021
@magda-chrzescian magda-chrzescian mentioned this issue Jul 22, 2021
Merged
mlewand added a commit that referenced this issue Jul 27, 2021
@mlewand
Merge pull request #10200 from ckeditor/ck/10146-find-in-multiroot
b7b3124 
Fix (find-and-replace): Find and replace feature now works correctly with a multi-root editor. Closes #10146.

Tests (find-and-replace): Added automatic and manual tests for the find and replace feature with a multi-root editor. See #10146.

Docs: Added the find and replace feature to the multi-root editor example.
@mlewand mlewand mentioned this issue Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
package:find-and-replace squad:core Issue to be handled by the Core team. squad:features Issue to be handled by the Features team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 45 (v29.1.0)
Development

Successfully merging a pull request may close this issue.

Ck/10146 find in multiroot ckeditor/ckeditor5
3 participants
@mlewand @magda-chrzescian @108signals