-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ckeditor5 version 27.1 doesnt get the ngmodel with angular #9620
Comments
same issue. can we create a previous version build using online builder ? |
@pulkitpatel95 you must compile it using the version 26 by yourself |
in the following file of the package ckeditor5-angular It seems that the the method "writeValue" doesn't make it job correctly (line 240 to 245) We can correct that by adding a line in the method "setUpEditorEvents" If we add the following line: So From that: We move to that:
It's clearly a problem to know when the CKEditor is initialized .... I hope it will help your developers |
Much better It must be done in the method "attachToWatchdog" (line 285) so the line: With this modification the line 253,254,255 can be commented/removed |
Hi @ldoreillepro, Thanks for reporting the issue and the PR, I confirm the issue.
Unfortunately, this is not a good fix as we need to have real-time editing in mind and support it as well. But, perhaps, we can extend the configuration with the initial data. I'll check it. Interestingly, I don't recall any recent CKEditor 5 change that broke the current solution 😅 |
Hi @ma2ciek , Any update on above issue or when we can expect a fix for this ? |
Fix: Fixed setting data on the editor component when the component is initializing. Closes ckeditor/ckeditor5#9620.
The fix landed on the master branch. We plan to release it at the beginning of the next week. |
From the version 27.1, with angular, we can use the @input data correctly but not the @input ngModel which cannot download the content into the ckeditor.
So we start with an empty editor.
This is a basic code to reproduce the problem
https://github.com/ldoreillepro/ldoreillepro-test-angular-ckeditor5-27-1
I only added a basic ckeditor in thefolder src/app
The text was updated successfully, but these errors were encountered: