Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting data on the editor component when the component is initializing #263

Merged
merged 4 commits into from
Jun 25, 2021

Conversation

ma2ciek
Copy link
Contributor

@ma2ciek ma2ciek commented Jun 21, 2021

Suggested merge commit message (convention)

Fix: Fixed setting data on the editor component when the component is initializing. Closes ckeditor/ckeditor5#9620.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@ma2ciek ma2ciek requested a review from pomek June 21, 2021 15:51

expect( component.editorInstance!.getData() ).toEqual( '<p>bar</p>' );
} );

it( 'should not be set using `editor.setData()` during the initialization step', () => {
Copy link
Contributor Author

@ma2ciek ma2ciek Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not sure about the original test. I don't see anything wrong with using editor.setData() on a data property change from outside of the editor component. This can't work with RTE anyway.

@ma2ciek ma2ciek mentioned this pull request Jun 21, 2021
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I ask about checking the current version of the code with the following versions (for all packages)?

  • 27.0.0
  • 27.1.0

We already know that it works with 28.0.0.

@pomek
Copy link
Member

pomek commented Jun 25, 2021

Also, it would be good to downgrade Angular to the previous version and verify whether it still works. It will prevent us from bumping minor/patch if we will introduce a BC.

@ma2ciek
Copy link
Contributor Author

ma2ciek commented Jun 25, 2021

Could I ask about checking the current version of the code with the following versions (for all packages)?

  • 27.0.0
  • 27.1.0

We already know that it works with 28.0.0.

Done ✅

Also, it would be good to downgrade Angular to the previous version and verify whether it still works. It will prevent us from bumping minor/patch if we will introduce a BC.

I haven't tested it but it should not have an effect. However, it would be nice if we could someday create e2e and unit tests against multiple Angular versions.

@pomek pomek merged commit bdfabf4 into master Jun 25, 2021
@pomek pomek deleted the cke/9620 branch June 25, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ckeditor5 version 27.1 doesnt get the ngmodel with angular
2 participants