Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IME issues #802

Closed
Reinmar opened this issue Jan 31, 2018 · 10 comments
Closed

IME issues #802

Reinmar opened this issue Jan 31, 2018 · 10 comments
Labels
domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). resolution:expired This issue was closed due to lack of feedback. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Reinmar
Copy link
Member

Reinmar commented Jan 31, 2018

Umbrella ticket for all issues related to IME (Input Method Engine) support. They concern users typing in languages such as Japanese, Korean, Chinese, etc.

@Reinmar
Copy link
Member Author

Reinmar commented Jan 31, 2018

do-not-edit-start-codetree-epic-issues

Issues in this epic:

Title Milestone Assignees Stage State
[Safari] The first line of each paragraph cannot be input into Chinese #1333 nice-to-have N/A Open
IndexSizeError iPad Japanese characters #992 backlog N/A Open
Pressing enter moves the last character to a new line when typing Hangul (Korean) #777 N/A N/A Closed
Japanese input (IME) fails at the first character in a paragraph #748 N/A N/A Closed
do-not-edit-end-codetree-epic-issues

@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. candidate:1.0.0 labels Jan 31, 2018
@f1ames
Copy link
Contributor

f1ames commented Feb 27, 2018

@f1ames
Copy link
Contributor

f1ames commented Feb 28, 2018

The general idea behind fixing IME issues is to apply few changes in how rendering works and check which issues are covered:

  1. Prevent selection re-rendering during composition - https://github.com/ckeditor/ckeditor5-engine/issues/460.
  2. Prevent inline filler, block filler removal during composition - https://github.com/ckeditor/ckeditor5-engine/issues/898.
  3. Renderer should use smart methods to update text nodes (see CharacterData.replaceData method) - https://github.com/ckeditor/ckeditor5-engine/issues/403.
  4. Block rendering DOM fragment during composition - see T/460 Selection rendering breaks composition ckeditor5-engine#861 for in-depth discussion on this topic.

@pjasiun
Copy link

pjasiun commented Feb 28, 2018

Block rendering DOM fragment during composition.

Keep in mind it needs to work well in collaborative editing.

@Reinmar
Copy link
Member Author

Reinmar commented Feb 28, 2018

Block rendering DOM fragment during composition.

Keep in mind it needs to work well in collaborative editing.

I'd rephrase it to: It must not break collaborative editing, but the MVP here doesn't mean that IME must work flawlessly in collaborative editing. Having IME working fine during collaborative editing is the next step.

@f1ames
Copy link
Contributor

f1ames commented Mar 6, 2018

From what I checked, preventing selection manipulation during composition is not enough to solve any of the above issues. Usually the cause is related to elements rerendering (which also may cause selection to be rerender) or both (a little more insight in https://github.com/ckeditor/ckeditor5-engine/issues/1334#issuecomment-370739811).

Not sure if we should go with prevent selection re-rendering during composition as a first one in this case also because of the fact that when updating rendering mechanism (I mean further issues mentioned in #802 (comment)), selection handling may also need to be modified. WDYT @Reinmar ?

@gaoryrt
Copy link

gaoryrt commented Sep 11, 2019

You guys did a lot on IME issues,
really helped me,
thank you all sincerely.

@Reinmar Reinmar added the domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). label Nov 18, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). resolution:expired This issue was closed due to lack of feedback. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

7 participants