Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safari][IME] Autocorrection changes content after composition in specific cases. #3079

Closed
f1ames opened this issue Mar 13, 2017 · 4 comments
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.

Comments

@f1ames
Copy link
Contributor

f1ames commented Mar 13, 2017

With Spanish-ISO keyboard (accent under ').

Case 1:

  1. <h2>Headin[]g 1</h2>
  2. Press accent
  3. Press esc
  4. Results in <h2>Heading'[]g 1</h2>

Case 2:

  1. <p>Hea[]ding 2</p>
  2. Press accent
  3. Press bold
  4. Type y
  5. Results in <p>He<strong>y</strong>´ding 2</p> and Throws TypeError: null is not an object (evaluating 'viewBlock.parent') in _defaultToModelPosition — mapper.js:222

With auto correct turned off, everything works fine in the above cases.

@f1ames f1ames changed the title [Safari] Autocorrection changes content after composition in specific cases. [Safari][IME] Autocorrection changes content after composition in specific cases. Mar 13, 2017
@Reinmar
Copy link
Member

Reinmar commented Mar 17, 2017

I couldn't reproduce it but my Safari behaves a bit differently than @f1ames's. On his macOS the word is underlined with blue dotted border. On my with red. This means that some other system kicks in.

@f1ames
Copy link
Contributor Author

f1ames commented Feb 27, 2018

It seems it may be more related to autocorrect than IME itself:
feb-27-2018 15-21-15 safari

Also confirming that above scenarios are still reproducible:
feb-27-2018 15-02-31-safari

@f1ames
Copy link
Contributor Author

f1ames commented May 30, 2018

Ok, I was able to partially reproduce the scenarios shown above (https://github.com/ckeditor/ckeditor5-typing/issues/85#issuecomment-368893835). You have to turn on the autocorrection in Safari:

image

But it behaves a little different than before so I suspect something changed after Safari/macOS update:

  1. <p>Hea[]ding 2</p>.
  2. Delete character before selection (Backspace).
  3. Type a.
  4. Type <.

Hea is replaced with Hey by autocorrect. This is not an issue as no errors are thrown, this is the way autocorrection works. I was not able to reproduce any of two initial scenarios (looks like autocorrection doesn't kicks in that easily while typing inside a word).

heading

I'm closing this issue as it is not reproducible any longer.

Not sure how we should label it in this case? cc @Reinmar

@f1ames f1ames closed this as completed May 30, 2018
@Reinmar
Copy link
Member

Reinmar commented Jun 11, 2018

Not sure how we should label it in this case? cc @Reinmar

As fixed. Someone fixed it :D

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added resolution:solved type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants