Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor crashes when pressing tab in a table cell with selection on an image #6607

Closed
oleq opened this issue Apr 15, 2020 · 5 comments · Fixed by #6752
Closed

Editor crashes when pressing tab in a table cell with selection on an image #6607

oleq opened this issue Apr 15, 2020 · 5 comments · Fixed by #6752
Assignees
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@oleq
Copy link
Member

oleq commented Apr 15, 2020

📝 Provide detailed reproduction steps (if any)

  1. Go to https://ckeditor.com/docs/ckeditor5/latest/features/table.html.
  2. Upload an image in a table cell (as the last child).
  3. Select the image.
  4. Tab.

✔️ Expected result

Probably the new table row should be created (or some sort of navigation).

❌ Actual result

The editor crashes.

2020-04-15 12 54 41

downcast.js:491 Uncaught TypeError: Cannot read property 'getChildren' of undefined
    at getExistingTableSectionElement (downcast.js:491)
    at getOrCreateTableSection (downcast.js:480)
    at DowncastDispatcher.<anonymous> (downcast.js:114)
    at DowncastDispatcher.fire (emittermixin.js:209)
    at DowncastDispatcher._testAndFire (downcastdispatcher.js:474)
    at DowncastDispatcher.convertInsert (downcastdispatcher.js:185)
    at DowncastDispatcher.convertChanges (downcastdispatcher.js:137)
    at editingcontroller.js:93
    at View.change (view.js:479)
    at Document.EditingController.listenTo.priority (editingcontroller.js:92)

📃 Other details

It exists prior to it31.

Have you seen this before @jodator, @ckeditor/qa-team?


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Apr 15, 2020
@FilipTokarski
Copy link
Member

Never seen it before. Unfortunately, it seems that it exists since version 18 (15, 16, 17 are ok).

@Mgsy Mgsy added the type:regression This issue reports a bug that was not present in the previous releases. label Apr 15, 2020
@jodator
Copy link
Contributor

jodator commented Apr 16, 2020

This is highly weird. But I'd like to look at it after conversion in table fix PR: ckeditor/ckeditor5-table#301. Might be also related to the ckeditor/ckeditor5-table#304.

@FilipTokarski
Copy link
Member

Bisection gives this output:

ae2f366204e38e630342fc7153cde2db09b30f89 is the first bad commit
commit ae2f366204e38e630342fc7153cde2db09b30f89
Author: Travis CI User <[email protected]>
Date:   Tue Mar 3 21:24:21 2020 +0000

    Revision: https://github.com/ckeditor/ckeditor5-table/commit/f3d1dee9973f1c23d2c5fb4035b747e871bf18e2

:100644 100644 075fe59ce7d9e9457d517e1a301aa44cee137d91 22e8b112f8734b1bdd85eb44a4d998ffd42eda56 M	mrgit.json

@jodator jodator added this to the next milestone Apr 16, 2020
@jodator jodator self-assigned this Apr 16, 2020
@jodator
Copy link
Contributor

jodator commented Apr 20, 2020

Let's see this after ckeditor/ckeditor5-table#304.

@jodator
Copy link
Contributor

jodator commented Apr 29, 2020

Unfortunately it doesn't :/

@jodator jodator modified the milestones: next, iteration 32 Apr 30, 2020
jodator added a commit that referenced this issue May 7, 2020
Fix (table): Fixed insert table row/column commands when a widget is selected inside the table cell. Closes #6607.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
5 participants