This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
I/6437: Fix - the table breaks after removing a last header row #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using full markup in tests without helper functions acts as documentation for this part of table conversion.
This change reflects how the code is used by commands.
…bute will now properly clean empty table sections.
|
The fix doesn't work for me. There is no tbody in the view when I remove the row. |
|
@Reinmar So after some digging up I ended up in fixing another set of tests (refs ckeditor/ckeditor5#6574). Apart of that I've also added removing empty table sections when down casting headings rows change. |
…g table modifications.
# Conflicts: # src/tableutils.js
|
@Reinmar the current PR is probably the last one for row headings + removing rows problems. Any change of this code will blows something different and the longer explanation is here: ckeditor/ckeditor5#6630. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Removing the last header row no longer breaks the table in the editing view. Closes ckeditor/ckeditor5#6437.
Additional information
The actual fix is in 242a2e0 commit. It turned out that the tests weren't written in the same way as row removing is implemented (df80eec).Removing row from a header section involves changingheadingRowsattribute on a table.The rest of the changes in tests was done due to ckeditor/ckeditor5#6574.