Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the form header UI component and re-use it in special characters dropdown #6109

Closed
oleq opened this issue Jan 22, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-ui#546
Closed

Extract the form header UI component and re-use it in special characters dropdown #6109

oleq opened this issue Jan 22, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-ui#546
Assignees
@panr
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:special-characters package:table type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 31 (v19...

Comments

@oleq
Copy link
Member

oleq commented Jan 22, 2020

Provide a description of the task

A follow-up of #6049.

ATM the component is used in the table (cell) properties form:

image

and has no formal structure (separate file, class name, etc.). It should be re–used in the special characters dropdown:

image

Note: there should be no spacing around the category dropdown then (also no rounder corners on the left side).
@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". package:table domain:ui/ux This issue reports a problem related to UI or UX. package:special-characters labels Jan 22, 2020
@oleq oleq mentioned this issue Jan 22, 2020
Merged
@oleq oleq added this to the iteration 29 milestone Jan 23, 2020
@Reinmar Reinmar modified the milestones: iteration 29, iteration 30 Feb 6, 2020
@Reinmar Reinmar modified the milestones: iteration 30, next Feb 21, 2020
@panr panr self-assigned this Mar 12, 2020
This was referenced Mar 17, 2020
Merged
Merged
Merged
Merged
jodator added a commit to ckeditor/ckeditor5-special-characters that referenced this issue Mar 26, 2020
@jodator
Merge pull request #15 from ckeditor/i/6109
342a536 
Other: Made `SpecialCharactersNavigationView` an instance of the new `FormHeaderView` UI. See ckeditor/ckeditor5#6109.

BREAKING CHANGE: From now the `SpecialCharactersNavigationView` is an instance of the `FormHeaderView` and unnecessary `SpecialCharactersNavigationView#labelView` was removed.
jodator added a commit to ckeditor/ckeditor5-table that referenced this issue Mar 26, 2020
@jodator
Merge pull request #281 from ckeditor/i/6109
f5b2faf 
Other: Replaced custom `FormHeaderView` with the new reusable `FormHeaderView` UI. See ckeditor/ckeditor5#6109.
jodator added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Mar 26, 2020
@jodator
Merge pull request #273 from ckeditor/i/6109
ceeb767 
Other: Changed styles of SpecialCharacters and Dropdown to match FormHeaderView component styles. See ckeditor/ckeditor5#6109.
jodator added a commit to ckeditor/ckeditor5-ui that referenced this issue Mar 26, 2020
@jodator
Merge pull request #546 from ckeditor/i/6109
eb1ce18 
Feature: Introduce `FormHeaderView` UI component. Closes ckeditor/ckeditor5#6109.
@mlewand mlewand modified the milestones: next, iteration 31 Mar 26, 2020
@oleq oleq mentioned this issue Mar 27, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:special-characters package:table type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

I/6109: Add FormHeaderView component ckeditor/ckeditor5-ui
4 participants
@Reinmar @oleq @panr @mlewand