Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/6109: Change styling of some elements to match FormHeaderView component #273

Merged
merged 4 commits into from
Mar 26, 2020

Conversation

panr
Copy link
Contributor

@panr panr commented Mar 17, 2020

Suggested merge commit message (convention)

Other: Changed styles of SpecialCharacters and Dropdown to match FormHeaderView component styles. See ckeditor/ckeditor5#6109.


Main PR: ckeditor/ckeditor5-ui#546

Additional information

specialcharacters

  • We slightly increased horizontal padding of some elements in SpecialCharacters UI to match FormHeaderView UI spacing.
  • We added .ck-dropdown__button_label-width_auto class and applied it to the DropdownButton in SpecialCharactersNavigationView, because the old styling have made the button too wide. New styling also fixed the gap between text and arrow icon.

@panr panr added the pr:sub label Mar 17, 2020
@jodator jodator self-assigned this Mar 26, 2020
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS the changes in the CSS files are mostly due to moving stuff around. The visual aspect is also fine for me. Looks good 👍

@jodator jodator merged commit ceeb767 into master Mar 26, 2020
@jodator jodator deleted the i/6109 branch March 26, 2020 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants