Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing enter in the todolist created from code block crashes the editor #5866

Closed
ma2ciek opened this issue Nov 28, 2019 · 3 comments · Fixed by #7562
Closed

Pressing enter in the todolist created from code block crashes the editor #5866

ma2ciek opened this issue Nov 28, 2019 · 3 comments · Fixed by #7562
Assignees
@niegowski
Labels
package:enter package:list support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 34 (v21...

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Nov 28, 2019

📝 Provide detailed reproduction steps (if any)

  1. Create a code block that contains a few lines
  2. Change it to todo-list
  3. Press enter after the first line

✔️ Expected result

No crash

❌ Actual result

Crash

📃 Other details

  • Browser: All
  • OS: macOS
  • CKEditor version: latest 15.0.0 (before the release)
  • Installed CKEditor plugins: CodeBlock, TodoList

todolist

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@ma2ciek ma2ciek added type:bug This issue reports a buggy (incorrect) behavior. package:list package:code-block status:confirmed labels Nov 28, 2019
@Reinmar
Copy link
Member

Reinmar commented Nov 28, 2019

It's not a DUP of #5779 per se, but it's the same problem – converters are not expecting any inline elements or any other markup.

@Reinmar Reinmar modified the milestones: iteration 28, iteration 29 Nov 28, 2019
@Reinmar
Copy link
Member

Reinmar commented Nov 28, 2019

In this case, it crashes because you have <br>s in that newly created list item.

@Reinmar Reinmar self-assigned this Nov 28, 2019
@Reinmar Reinmar modified the milestones: iteration 29, nice-to-have, next Jan 28, 2020
@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Feb 26, 2020
@wwalc wwalc mentioned this issue Apr 9, 2020
Closed
@Reinmar
Copy link
Member

Reinmar commented Apr 9, 2020

Another case: #6585.

@Reinmar Reinmar removed their assignment Jun 18, 2020
@Reinmar Reinmar modified the milestones: next, iteration 34 Jun 23, 2020
@niegowski niegowski mentioned this issue Jul 6, 2020
Merged
jodator added a commit that referenced this issue Jul 8, 2020
@jodator
Merge pull request #7562 from ckeditor/i/5866
3d26015 
Fix (list): Editor should not crash on the enter keypress inside a to-do list item containing soft-breaks. Closes #5866. Closes #6585.

Fix (list): Links inside a to-do list item should be properly converted to HTML. Closes #5779.

Feature (engine): Changed visibility scope of `Mapper#findPositionIn()` from `private` to `public`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:enter package:list support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 34 (v21.0.0)
Development

Successfully merging a pull request may close this issue.

#5866: To-do lists down-casting refactored ckeditor/ckeditor5
5 participants
@Reinmar @niegowski @ma2ciek @mlewand @lslowikowska