Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a link to a to-do list item produces incorrect HTML #5779

Closed
Mgsy opened this issue Nov 22, 2019 · 4 comments · Fixed by #7562
Closed

Adding a link to a to-do list item produces incorrect HTML #5779

Mgsy opened this issue Nov 22, 2019 · 4 comments · Fixed by #7562
Assignees
Labels
support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Mgsy
Copy link
Member

Mgsy commented Nov 22, 2019

📝 Provide detailed reproduction steps (if any)

  1. Open the to-do list manual test.
  2. Create a new to-do list with 1 list item and a few words.
  3. Select the first word.
  4. Add a link.

✔️ Expected result

In the preview, the link is added only to the first word.

❌ Actual result

In the preview, the link is added to the whole list item.

📃 Other details

bug_cke5

Related - #5775


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed support:2 An issue reported by a commercially licensed client. labels Nov 22, 2019
@Reinmar
Copy link
Member

Reinmar commented Nov 22, 2019

cc @jodator @oskarwrobel – didn't we already talk about this? I think we even had it reported but I couldn't find a ticket.

@Reinmar Reinmar modified the milestones: next, iteration 28 Nov 22, 2019
@jodator
Copy link
Contributor

jodator commented Nov 22, 2019

Looks a bit similar to this: ckeditor/ckeditor5-list#154.

@Reinmar
Copy link
Member

Reinmar commented Nov 25, 2019

Looks exactly like the last comment in this thread :D That's why it sounded familiar.

@Reinmar
Copy link
Member

Reinmar commented Nov 25, 2019

The data downcast is, unfortunately, really broken. Soft breaks also causes some interesting results:

<ul class="todo-list">
  <li>
    <label class="todo-list__label">
      <input type="checkbox" disabled="disabled">
      <span class="todo-list__label__description">dsf</span>
    </label>
    <br>
    <label class="todo-list__label">
      <span class="todo-list__label__description">dsf</span>
    </label>
  </li>
</ul>"

@Reinmar Reinmar modified the milestones: iteration 28, iteration 29 Nov 26, 2019
@Reinmar Reinmar modified the milestones: iteration 29, next Jan 28, 2020
@niegowski niegowski assigned niegowski and unassigned Reinmar Jul 6, 2020
jodator added a commit that referenced this issue Jul 8, 2020
Fix (list): Editor should not crash on the enter keypress inside a to-do list item containing soft-breaks. Closes #5866. Closes #6585.

Fix (list): Links inside a to-do list item should be properly converted to HTML. Closes #5779.

Feature (engine): Changed visibility scope of `Mapper#findPositionIn()` from `private` to `public`.
@Reinmar Reinmar modified the milestones: next, iteration 34 Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants