-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a link to a to-do list item produces incorrect HTML #5779
Labels
Milestone
Comments
Mgsy
added
type:bug
This issue reports a buggy (incorrect) behavior.
status:confirmed
support:2
An issue reported by a commercially licensed client.
labels
Nov 22, 2019
cc @jodator @oskarwrobel – didn't we already talk about this? I think we even had it reported but I couldn't find a ticket. |
Looks a bit similar to this: ckeditor/ckeditor5-list#154. |
Looks exactly like the last comment in this thread :D That's why it sounded familiar. |
The data downcast is, unfortunately, really broken. Soft breaks also causes some interesting results: <ul class="todo-list">
<li>
<label class="todo-list__label">
<input type="checkbox" disabled="disabled">
<span class="todo-list__label__description">dsf</span>
</label>
<br>
<label class="todo-list__label">
<span class="todo-list__label__description">dsf</span>
</label>
</li>
</ul>" |
jodator
added a commit
that referenced
this issue
Jul 8, 2020
Fix (list): Editor should not crash on the enter keypress inside a to-do list item containing soft-breaks. Closes #5866. Closes #6585. Fix (list): Links inside a to-do list item should be properly converted to HTML. Closes #5779. Feature (engine): Changed visibility scope of `Mapper#findPositionIn()` from `private` to `public`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
📝 Provide detailed reproduction steps (if any)
✔️ Expected result
In the preview, the link is added only to the first word.
❌ Actual result
In the preview, the link is added to the whole list item.
📃 Other details
Related - #5775
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: