Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Indent in all builds and BlockIndent in the decoupled-document #1844

Closed
Reinmar opened this issue Jun 28, 2019 · 8 comments
Closed

Enable Indent in all builds and BlockIndent in the decoupled-document #1844

Reinmar opened this issue Jun 28, 2019 · 8 comments
Assignees
Labels
status:discussion type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 28, 2019

The case with Indent is – we want the indent/outdent buttons in all builds toolbars because it's the only way to indent/outdent lists on mobiles. Related: #868.

The problem – lack of space in their toolbars. Related: #894.

The case with BlockIndent in decoupled-document is quite obvious, I think – it's a document feature.

However, it's an even bigger problem with too many buttons in the toolbar there.

@Reinmar Reinmar added status:discussion type:improvement This issue reports a possible enhancement of an existing feature. labels Jun 28, 2019
@Reinmar Reinmar added this to the iteration 26 milestone Jun 28, 2019
@Reinmar
Copy link
Member Author

Reinmar commented Aug 12, 2019

Waiting for ckeditor/ckeditor5-ui#451, for now. Though, the decision still has to be made.

Also, perhaps we could have a split button for indentation? If 90% of the time you're indenting things, then perhaps it will be better? It will take less space.

cc @oleq @dkonopka

@Reinmar Reinmar modified the milestones: iteration 26, iteration 27 Aug 12, 2019
@Reinmar Reinmar self-assigned this Aug 27, 2019
@dkonopka
Copy link
Contributor

dkonopka commented Oct 15, 2019

It's true, we should think all the time about space inside the toolbar, but I have one doubt about this new split button: the icon. How we could visualise indent&outdent together or I just misunderstand you and we will make it same as text alignment?

Anyway, some maths here: we could save around 20 pixels (two buttons ~ 60px, when one split button ~40px), so IMHO it's worth to think about it. OTOH, it's still one click more for users to use this feature.

savings

Note: I've researched the most popular editors and there is no usage of indent/outdent action inside a dropdown.

@oleq
Copy link
Member

oleq commented Oct 15, 2019

I created a PoC but I don't think we can deliver it in i27:

  • It's a considerable piece of code (missing tests),
  • There's also the question of whether the main button should be dynamic based on the last command used (UX to discuss).

Kapture 2019-10-15 at 14 08 07

@oleq
Copy link
Member

oleq commented Oct 16, 2019

Another PoC except that the main button is always indenting (it does not change its role).

Kapture 2019-10-16 at 11 17 05

Reinmar added a commit to ckeditor/ckeditor5-build-decoupled-document that referenced this issue Oct 16, 2019
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
Reinmar added a commit to ckeditor/ckeditor5-build-inline that referenced this issue Oct 16, 2019
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Oct 16, 2019
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
Reinmar added a commit to ckeditor/ckeditor5-build-balloon-block that referenced this issue Oct 16, 2019
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
Reinmar added a commit to ckeditor/ckeditor5-build-balloon that referenced this issue Oct 16, 2019
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
@Reinmar
Copy link
Member Author

Reinmar commented Oct 16, 2019

I merged @oleq's PR in builds. The remaining things is adding indent/outdent in several guides in the docs. Will handle this.

@Reinmar
Copy link
Member Author

Reinmar commented Oct 16, 2019

This is a problem now :( But the good thing is that I can increase the max width in this guide now.

image

@Reinmar
Copy link
Member Author

Reinmar commented Oct 16, 2019

☝️ I actually extracted this to #5598

Reinmar added a commit to ckeditor/ckeditor5-autoformat that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-alignment that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-core that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-heading that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-font that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-highlight that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-horizontal-line that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-link that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-list that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-markdown-gfm that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-media-embed that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-ui that referenced this issue Oct 16, 2019
Reinmar added a commit to ckeditor/ckeditor5-word-count that referenced this issue Oct 16, 2019
@Reinmar
Copy link
Member Author

Reinmar commented Oct 16, 2019

OMG, I think I updated all the toolbars that were worth it. But maintaining all those configurations is awful :<

@Reinmar Reinmar closed this as completed Oct 16, 2019
JDinABox pushed a commit to JDinABox/ckeditor5-build-markdown that referenced this issue Sep 6, 2021
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants