Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar starts to wrap #894

Closed
Reinmar opened this issue Mar 13, 2018 · 8 comments
Closed

Toolbar starts to wrap #894

Reinmar opened this issue Mar 13, 2018 · 8 comments
Labels
status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 13, 2018

image

Well... we said that we ignore this scenario for now because it's the implementor's role to take care of this (by not using too many features or using wide enough toolbar. And here we are ;)

@oleq
Copy link
Member

oleq commented Mar 14, 2018

We need a dynamic grouping mechanism I described before #817 (comment)

image
image

@Reinmar
Copy link
Member Author

Reinmar commented Mar 15, 2018

BTW, in examples, there's no ToC on the right, so we might make the content a bit wider.

@oleq
Copy link
Member

oleq commented Mar 16, 2018

I created a quick fix for the limited horizontal space issue by adjusting the Umberto container width in the examples/builds/document-editor.html (see the commit). Unfortunately, we cannot use this fix in the guide (framework/guides/ui/document-editor.html) because it has the TOC on the right side, which limits the space.

We might need some option in Umberto to use a wider layout when necessary for examples/guides like this one.

@Reinmar
Copy link
Member Author

Reinmar commented Jan 21, 2019

In #1472 @dashingswags proposed a bit different approach to the UI (the 3 dots and the menu look). I quite liked it. We don't have such a component your so we'd need to think how to propose it (to avoid weird duplication) if we want to make it reusable. If not, we could just implement similar look&feel.

One issue that I see with #dashingswags's solution is that dropdowns or split buttons won't work in such a panel. Would this be a deal breaker?

@Reinmar Reinmar added type:improvement This issue reports a possible enhancement of an existing feature. type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels Jan 21, 2019
@Reinmar Reinmar added this to the next milestone Jan 21, 2019
@dashingswags
Copy link

dashingswags commented Jan 21, 2019

Tested with dropdowns before initiating a pull request which works well too.
samples with screenshots would be uploaded on the issue page just to show variations

@dashingswags
Copy link

screenshot 187
screenshot 188

@jodator
Copy link
Contributor

jodator commented Feb 19, 2019

Also on mobile:
2019-02-19 14 46 34

@oleq
Copy link
Member

oleq commented Oct 15, 2019

Closed in #416.

@oleq oleq closed this as completed Oct 15, 2019
@oleq oleq modified the milestones: nice-to-have, iteration 27 Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

4 participants