Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CKFinder work with track changes. #13213

Closed
kbinieda opened this issue Jan 4, 2023 · 0 comments · Fixed by #13214
Closed

Make CKFinder work with track changes. #13213

kbinieda opened this issue Jan 4, 2023 · 0 comments · Fixed by #13214
Assignees
@kbinieda
Labels
package:ckfinder squad:collaboration Issue to be handled by the Collaboration team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 60 (v36...

Comments

@kbinieda
Copy link
Contributor

kbinieda commented Jan 4, 2023

Since CKFinder uses commands that are already integrated with track changes, the only change that should be done is to mark ckfinder affectsData as false.

More information here: https://github.com/cksource/collaboration-features/issues/4267
@kbinieda kbinieda added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:ckfinder squad:collaboration Issue to be handled by the Collaboration team. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Jan 4, 2023
@kbinieda kbinieda self-assigned this Jan 4, 2023
@kbinieda kbinieda mentioned this issue Jan 4, 2023
Merged
scofalik added a commit that referenced this issue Jan 9, 2023
@scofalik
Merge pull request #13214 from ckeditor/ck/13213-ckfinder-track-changes
1b95b17 
Feature (track-changes): Add track changes integration for CKFinder feature.

Other (ckfinder): Set correct value (`false`) for `CKFinderCommand#affectsData`. Now, the command's state depends only on related commands (`insertImage` and `link`). Closes #13213.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 9, 2023
@CKEditorBot CKEditorBot added this to the iteration 60 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbinieda kbinieda

Labels
package:ckfinder squad:collaboration Issue to be handled by the Collaboration team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 60 (v36.0.0)
Development

Successfully merging a pull request may close this issue.

Set correct value (false) for CKFinderCommand#affectsData ckeditor/ckeditor5
2 participants
@kbinieda @CKEditorBot