Merge pull request #13214 from ckeditor/ck/13213-ckfinder-track-changes

Feature (track-changes): Add track changes integration for CKFinder feature. Other (ckfinder): Set correct value (`false`) for `CKFinderCommand#affectsData`. Now, the command's state depends only on related commands (`insertImage` and `link`). Closes #13213.
ckeditor · Jan 9, 2023 · 1b95b17 · 1b95b17
2 parents ba63580 + 3c23f8f
commit 1b95b17
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/packages/ckeditor5-ckfinder/src/ckfindercommand.js b/packages/ckeditor5-ckfinder/src/ckfindercommand.js
@@ -33,6 +33,9 @@ export default class CKFinderCommand extends Command {
 	constructor( editor ) {
 		super( editor );
 
+		// The CKFinder command does not affect data by itself.
+		this._affectsData = false;
+
 		// Remove default document listener to lower its priority.
 		this.stopListening( this.editor.model.document, 'change' );
 

diff --git a/packages/ckeditor5-ckfinder/tests/ckfindercommand.js b/packages/ckeditor5-ckfinder/tests/ckfindercommand.js
@@ -455,4 +455,10 @@ describe( 'CKFinderCommand', () => {
 			mockFinderEvent( 'files:choose', data );
 		}
 	} );
+
+	describe( '_affectsData', () => {
+		it( 'does not affect data', () => {
+			expect( command._affectsData ).to.be.false;
+		} );
+	} );
 } );