Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS MVP] Automated tests should be able to cover code written in TypeScript #11716

Closed
arkflpc opened this issue May 6, 2022 · 1 comment · Fixed by ckeditor/ckeditor5-dev#767
Closed

[TS MVP] Automated tests should be able to cover code written in TypeScript #11716

arkflpc opened this issue May 6, 2022 · 1 comment · Fixed by ckeditor/ckeditor5-dev#767
Assignees
@arkflpc
Labels
domain:ts package:dev squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 54 (v34...

Comments

@arkflpc
Copy link
Contributor

arkflpc commented May 6, 2022 •
edited
Loading

We need the possibility of running automated tests for packages that contain TypeScript code (like #11715).

Tests themselves doesn't have to be in TypeScript (imo, reimplementing them has the lowest value).

Part of #11708.
@arkflpc arkflpc added squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos". domain:ts and removed type:task This issue reports a chore (non-production change) and other types of "todos". labels May 6, 2022
@arkflpc arkflpc mentioned this issue May 6, 2022
Closed
@Reinmar
Copy link
Member

Reinmar commented May 9, 2022 •
edited
Loading

Will cover:

  • the general support
  • test runner's features that should still work:
    • code coverage reports,
    • source maps,
    • file watcher,
    • break points, conditional break points (added via Chrome Dev tools),
  • the CK_DEBUG flag (the if statements)

Potentially useful link: https://istanbul.js.org/docs/tutorials/typescript/

@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 13, 2022
@arkflpc arkflpc self-assigned this May 13, 2022
@pomek pomek mentioned this issue May 30, 2022
Merged
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Jun 3, 2022
@pomek
Merge pull request #767 from ckeditor/ck/11716-typescript-tests
ada1875 
Feature (tests): Added support for running automated tests for the TypeScript code. Closes ckeditor/ckeditor5#11716.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 3, 2022
@CKEditorBot CKEditorBot added this to the iteration 54 milestone Jun 3, 2022
@Reinmar Reinmar mentioned this issue Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
domain:ts package:dev squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 54 (v34.2.0)
Development

Successfully merging a pull request may close this issue.

Run tests for code written in TypeScript ckeditor/ckeditor5-dev
3 participants
@Reinmar @arkflpc @CKEditorBot