Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS MVP] Rewrite ckeditor5-utils package to TypeScript #11715

Closed
arkflpc opened this issue May 6, 2022 · 0 comments
Closed

[TS MVP] Rewrite ckeditor5-utils package to TypeScript #11715

arkflpc opened this issue May 6, 2022 · 0 comments
Assignees
Labels
domain:ts package:utils squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@arkflpc
Copy link
Contributor

arkflpc commented May 6, 2022

We need to start moving CKEditor5 to TypeScript somewhere, and ckeditor5-utils is the perfect package to start with. That's because:

  1. It doesn't depend on anything else, so we won't introduce a TS package that depends on JS one.
  2. Most classes and functions are independent.
  3. It's quite stable, so the code won't diverge much from the master branch (it takes several tasks to merge it there).

Because we don't have any tooling supporting TS right now, let's keep the code on feature branch.

Exploiting the full potential of statically typed classes like Emitter or Observable can be tricky to do at the first attempt, so I wouldn't overcomplicate that. We can get back later. For instance, when rewriting ckeditor5-engine.

Part of #11708.

@arkflpc arkflpc added squad:core Issue to be handled by the Core team. domain:ts type:task This issue reports a chore (non-production change) and other types of "todos". package:utils labels May 6, 2022
@arkflpc arkflpc self-assigned this May 10, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 10, 2022
arkflpc added a commit that referenced this issue May 30, 2022
Other (utils): Rewrites ckeditor5-utils in TypeScript. Closes #11715.
@arkflpc arkflpc closed this as completed May 30, 2022
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 30, 2022
@CKEditorBot CKEditorBot added this to the upcoming milestone May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ts package:utils squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

3 participants