This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/79 - Use typing.undoStep in both InputCommand and DeleteCommand #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note – this is a breaking change and should be mentioned in the commit message. Of course, I don't think that anyone use this option already, but it's important to keep an eye on such aspects. |
|
@Reinmar, I will keep this in mind next time. I also updated the proposal for merge message with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Use
typing.undoStepin bothInputCommandandDeleteCommand. Closes ckeditor/ckeditor5#3077.BREAKING CHANGE: The
undo.stepconfiguration option was replaced bytyping.undoStepinDeleteCommand. Thetyping.undoStepworks in the same manner asundo.stepan should be used instead of it. See ckeditor/ckeditor5#3077.