Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are undo.step and typing.undoStep config options used. #3077

Closed
f1ames opened this issue Mar 6, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-typing#81
Closed

There are undo.step and typing.undoStep config options used. #3077

f1ames opened this issue Mar 6, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-typing#81
Assignees
@f1ames
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 9

Comments

@f1ames
Copy link
Contributor

f1ames commented Mar 6, 2017

The undo.step is used in DeleteCommand (deletecommand.js#L48) while typing.undoStep is used in InputCommand (input.js#L31). I believe this should be the same config option (and while it is in Typing package it should be named typing.undoStep probably)?

If those are supposed to be two different config options I find the naming quite confusing (from the API/config point of view).
@Reinmar
Copy link
Member

Reinmar commented Mar 6, 2017

I believe this should be the same config option (and while it is in Typing package it should be named typing.undoStep probably)?

👍

@f1ames f1ames self-assigned this Mar 6, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-typing Mar 7, 2017
@Reinmar
Merge pull request #81 from ckeditor/t/79
c597467 
Fix: Use `typing.undoStep` in both `InputCommand` and `DeleteCommand`. Closes #79.

BREAKING CHANGE: The `undo.step` configuration option was replaced by `typing.undoStep` in `DeleteCommand`. See #79.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
@f1ames f1ames mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f1ames f1ames

Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

T/79 - Use typing.undoStep in both InputCommand and DeleteCommand ckeditor/ckeditor5-typing
3 participants
@Reinmar @f1ames @mlewand