Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/5829: Enhance restricted editing feature styling #259

Merged
merged 6 commits into from
Feb 6, 2020
Merged

I/5829: Enhance restricted editing feature styling #259

merged 6 commits into from
Feb 6, 2020

Conversation

panr
Copy link
Contributor

@panr panr commented Dec 17, 2019

Suggested merge commit message (convention)

Other: Add hover state for all exeptions and fix width for collapsed exception in restricted editing. Closes ckeditor/ckeditor5#5829.

@Reinmar Reinmar self-assigned this Dec 18, 2019
Reinmar
Reinmar suggested changes Dec 18, 2019
View reviewed changes
Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You styled the :hover for both modes – the standard one and the restricted one. The goal is to style only the restricted mode. In the standard mode, the style should behave as a normal highlight.

This means that you need some class on this span or on the entire editable that will allow you to target this style only for a single mode.

@panr panr added the pr:sub label Dec 19, 2019
@panr panr mentioned this pull request Dec 19, 2019
Merged
@panr
Copy link
Contributor Author

panr commented Dec 19, 2019

You styled the :hover for both modes – the standard one and the restricted one. The goal is to style only the restricted mode. In the standard mode, the style should behave as a normal highlight.

This means that you need some class on this span or on the entire editable that will allow you to target this style only for a single mode.

Fixed in ckeditor/ckeditor5-restricted-editing#9 which has become main PR for the changes. I labeled this PR as a sub-pr.

@panr panr requested a review from Reinmar December 19, 2019 11:24
@panr
Copy link
Contributor Author

panr commented Jan 16, 2020

@Reinmar 🙏

@Reinmar Reinmar merged commit 08d6613 into master Feb 6, 2020
@Reinmar Reinmar deleted the i/5829 branch February 6, 2020 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Reinmar Reinmar Awaiting requested review from Reinmar

Assignees

@Reinmar Reinmar

Labels
pr:sub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance restricted editing feature styling
2 participants
@panr @Reinmar