This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
I/5829: Add additional classes to editable to differentiate styling for each mode #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panr
changed the title
Reinmar
reviewed
Dec 19, 2019
Reinmar
reviewed
Dec 19, 2019
Reinmar
reviewed
Dec 19, 2019
Reinmar
reviewed
Dec 19, 2019
|
Tests have been added. FYI: I loop over each root because in case if test environment changes to multiroot it will pass anyway. |
Reinmar
reviewed
Dec 20, 2019
| @@ -40,6 +40,12 @@ describe( 'RestrictedEditingModeEditing', () => { | |||
| expect( editor.plugins.get( RestrictedEditingModeEditing ) ).to.be.instanceOf( RestrictedEditingModeEditing ); | |||
| } ); | |||
|
|
|||
| it( 'should have "ck-restricted-editing_mode_restricted" class', () => { | |||
There was a problem hiding this comment.
Suggested change
| it( 'should have "ck-restricted-editing_mode_restricted" class', () => { | |
| it( 'all roots should have "ck-restricted-editing_mode_restricted" class', () => { |
Reinmar
reviewed
Dec 20, 2019
| @@ -35,6 +35,12 @@ describe( 'StandardEditingModeEditing', () => { | |||
| expect( editor.plugins.get( 'StandardEditingModeEditing' ) ).to.be.instanceOf( StandardEditingModeEditing ); | |||
| } ); | |||
|
|
|||
| it( 'should have "ck-restricted-editing_mode_standard" class', () => { | |||
There was a problem hiding this comment.
Suggested change
| it( 'should have "ck-restricted-editing_mode_standard" class', () => { | |
| it( 'all roots should have "ck-restricted-editing_mode_standard" class', () => { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Add hover state for all exeptions and fix width for collapsed exception in restricted editing. Closes ckeditor/ckeditor5#5829.
Additional information