Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The split button in the dropdown lacks many visual styles (hover, focus, on, etc.) #3393

Closed
oleq opened this issue Feb 9, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-theme-lark#147
Closed

The split button in the dropdown lacks many visual styles (hover, focus, on, etc.) #3393

oleq opened this issue Feb 9, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-theme-lark#147
Assignees
@oleq

Comments

@oleq
Copy link
Member

oleq commented Feb 9, 2018

A follow-up of fhttps://github.com/ckeditor/ckeditor5-theme-lark/issues/131.

ATM the split button implements a very limited styling, i.e.:

  • when any of the 2 buttons gets hovered/focused, the entire buttons should get a background color
  • there should be a vertical separator (border) between the action and arrow buttons, but visible only, when hovering/focusing or the panel is open

Actual

kapture 2018-02-09 at 15 18 15

Expected — a good example from Google Docs)

kapture 2018-02-09 at 15 21 01

@jodator @dkonopka
@oleq oleq changed the title The split button in the dropdown lacks visual styles (hover, focus, on, etc.) The split button in the dropdown lacks many visual styles (hover, focus, on, etc.) Feb 9, 2018
dkonopka referenced this issue in ckeditor/ckeditor5-ui Feb 20, 2018
@dkonopka
Merge pull request #373 from ckeditor/t/ckeditor5-theme-lark/134
d490d61 
Other: Added a CSS class to the SplitButtonView when the arrow is on (see ckeditor/ckeditor5-theme-lark#134).
dkonopka referenced this issue in ckeditor/ckeditor5-theme-lark Feb 20, 2018
@dkonopka
Merge pull request #147 from ckeditor/t/134
6db332e 
Other: Improved the visual styles of the split button when hovered or open. Closes [#134](https://github.com/ckeditor/ckeditor5-theme-lark/issues/134).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@oleq