Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/134: Improved the visual styles of the split button when hovered or open #147

Merged
merged 2 commits into from
Feb 20, 2018
Merged

T/134: Improved the visual styles of the split button when hovered or open #147

merged 2 commits into from
Feb 20, 2018

Conversation

oleq
Copy link
Member

@oleq oleq commented Feb 19, 2018 •
edited by pomek
Loading

Suggested merge commit message (convention)

Other: Improved the visual styles of the split button when hovered or open. Closes ckeditor/ckeditor5#3393.

Additional information

Demo

kapture 2018-02-19 at 18 41 12

@oleq oleq requested a review from dkonopka February 19, 2018 17:40
@dkonopka
Copy link
Contributor

screen shot 2018-02-20 at 09 34 35

We need @mixin ck-tooltip_disabled on focused ck-splitbutton__action && ck-dropdown__panel-visible here I guess.

@oleq
Copy link
Member Author

oleq commented Feb 20, 2018 •
edited
Loading

Let's do that in the follow-up.

It turned out a simple thing ckeditor/ckeditor5-ui@68587a4.

@dkonopka dkonopka merged commit 6db332e into master Feb 20, 2018
@oleq oleq deleted the t/134 branch February 20, 2018 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dkonopka dkonopka dkonopka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The split button in the dropdown lacks many visual styles (hover, focus, on, etc.)
2 participants
@oleq @dkonopka