Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using editor.setData() after editor's initialization #68

Closed
pomek opened this issue Feb 27, 2019 · 0 comments
Closed

Stop using editor.setData() after editor's initialization #68

pomek opened this issue Feb 27, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@pomek
Copy link
Member

pomek commented Feb 27, 2019

It causes the content of the initialized editor is being changed.

There is no problem if only a single user edits the content. But what if two and more users want to edit the editor. Every new connection will reset the editor to the initial state. The entire history of the document will disappear.

We need to find another way to set initialized data.

@pomek pomek self-assigned this Feb 27, 2019
@pomek pomek added this to the iteration 23 milestone Feb 27, 2019
ma2ciek added a commit that referenced this issue Feb 27, 2019
Fix: Fixed integration with collaboration features by changing the way how the initial data are passed to an editor instance. Previously the `<ckeditor>` component has been using the `editor.setData()` method which produces invalid results in collaboration. Now the initial data are injected directly into the container on which the editor will be created. Closes #68.
@pomek pomek modified the milestones: iteration 23, iteration 22 Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant