Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular integration should not use setData on the first data initialization #75

Closed
ma2ciek opened this issue Feb 27, 2019 · 0 comments
Closed

Angular integration should not use setData on the first data initialization #75

ma2ciek opened this issue Feb 27, 2019 · 0 comments
Assignees
@ma2ciek
Labels
status:discussion type:bug
Milestone
iteration 22

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Feb 27, 2019

It causes problems during collaboration when the second client connects - it resets the content -see more in ckeditor/ckeditor5-react#68 and #6 (comment).
@ma2ciek ma2ciek added this to the iteration 22 milestone Feb 27, 2019
ma2ciek added a commit that referenced this issue Feb 27, 2019
@ma2ciek
Fixed problem with initializing editor data. See #75.
51e51f0
@ma2ciek ma2ciek self-assigned this Feb 27, 2019
@ma2ciek ma2ciek mentioned this issue Feb 27, 2019
Merged
@pomek pomek closed this as completed in #76 Mar 5, 2019
pomek added a commit that referenced this issue Mar 5, 2019
@pomek
Merge pull request #76 from ckeditor/t/75
63c0073 
Fix: Fixed integration with collaboration features by changing the way how the initial data are passed to an editor instance. Previously the `<ckeditor>` component had been using the `editor.setData()` method which produces invalid results in collaboration. Now the initial data are injected directly into the container on which the editor will be created. Closes #75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
status:discussion type:bug
Projects
None yet
Milestone
iteration 22
Development

No branches or pull requests
1 participant
@ma2ciek