Allow basic d&d element/image in tables when tableselection is on #4951
Conversation
There was a problem hiding this comment.
Nice and clean solution 👍 I hope that disabling selection do not break anything ;) However all tests on chrome all green 🤞
I left a few inline comments. The most important is the one with d&d issue on chrome.
I think we could also add a mixed test, so d&d for mixed images with text content.
Also, please use the 4.17.1 tag as @jacekbogdanski suggested.
| <table border="1" cellpadding="1" cellspacing="1" style="width:500px"> | ||
| <tbody> | ||
| <tr> | ||
| <td><img alt="" src="https://via.placeholder.com/100" /> </td> |
There was a problem hiding this comment.
What is the purpose of this  ? Because without it - when I d&d image - it is pasted with additional borders 🤔
If you leave it, then it is possible to d&d image inside the same cell, but after  . Then when you d&d image to another cell it is copied with additional borders. It looks like it is copied with the entire table construction inside the td element.
There was a problem hiding this comment.
However, it occurs only in chrome... 🤔
There was a problem hiding this comment.
As you said, without d&d is breaking. I created a separate issue for this case. This problem occurs when tableselection and clipboard plugins are enabled.
|
Rebased on newest |
|
Rebased on newest |
KarolDawidziuk
force-pushed
the
t/547-2
branch
from
95eb1c8
to
9a148d2
Compare
|
Thanks, @sculpt0r for the review! Changes:
|
|
Rebased on newest mater. |
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
D&D in tables was unavailable because the
dragevent handler cancel this event.To allow it I just removed the part of the code responsible for the interrupting of the event and in the same handler updated the
fakeSelection.activeflag to stop table selection.This fix only allows moving only selected text and images. Trying to select an entire cell with
tableselectionand moving it fails.PS. This branch has this name because there is already one frozen PR for this issue.
Which issues does your PR resolve?
Closes #547.