Skip to content

Commit

Permalink
Fix ignoring manual tests, add proper bender tags and indentation fix
Browse files Browse the repository at this point in the history
  • Loading branch information
Karol Dawidziuk authored and sculpt0r committed Nov 23, 2021
1 parent ec7ece5 commit 06a15c8
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 24 deletions.
18 changes: 10 additions & 8 deletions tests/plugins/tableselection/manual/draganddropimage.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<table border="1" cellpadding="1" cellspacing="1" style="width:500px">
<tbody>
<tr>
<td><img alt="" src="https://via.placeholder.com/100" />&nbsp;</td>
<td><img alt="" src="http://via.placeholder.com/100" />&nbsp;</td>
<td>test</td>
</tr>
<tr>
Expand Down Expand Up @@ -30,13 +30,15 @@
</textarea>

<script>
if ( bender.tools.env.mobile ) {
bender.ignore();
}
( function() {
if ( bender.tools.env.mobile ) {
return bender.ignore();
}

bender.tools.ignoreUnsupportedEnvironment( 'tableselection' );
bender.tools.ignoreUnsupportedEnvironment( 'tableselection' );

CKEDITOR.replace('editor', {
height: 350
} );
CKEDITOR.replace( 'editor', {
height: 350
} );
} )();
</script>
13 changes: 7 additions & 6 deletions tests/plugins/tableselection/manual/draganddropimage.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
@bender-tags: dialog, __next__, 547, bug
@bender-tags: dialog, 4.17.1, 547, bug
@bender-ui: collapsed
@bender-ckeditor-plugins: wysiwygarea, toolbar, table, tableselection, image, undo, sourcearea, basicstyles
@bender-ckeditor-plugins: wysiwygarea, toolbar, table, tableselection, image, undo, sourcearea, basicstyles, elementspath


1. Open browser's console.
3. Using drag&drop move image to other table cell.

**Expected**

Image was moved properly, the content looking good and there is no error in the console.
* Image was moved properly.
* The content looking good and there is no error in the console.

**Unxpected**

Image was not moved.
There's error in the console.
After the image was moved, the table was modified - an extra cell was added.
* Image was not moved.
* There's error in the console.
* After the image was moved, the table was modified - an extra cell was added.
12 changes: 7 additions & 5 deletions tests/plugins/tableselection/manual/draganddroptext.html
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,13 @@
</textarea>

<script>
if ( bender.tools.env.mobile ) {
bender.ignore();
}
( function() {
if ( bender.tools.env.mobile ) {
return bender.ignore();
}

bender.tools.ignoreUnsupportedEnvironment( 'tableselection' );
bender.tools.ignoreUnsupportedEnvironment( 'tableselection' );

CKEDITOR.replace('editor');
CKEDITOR.replace( 'editor' );
} )();
</script>
11 changes: 6 additions & 5 deletions tests/plugins/tableselection/manual/draganddroptext.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@bender-tags: dialog, __next__, 547, bug
@bender-tags: dialog, 4.17.1 547, bug
@bender-ui: collapsed
@bender-ckeditor-plugins: wysiwygarea, toolbar, table, tableselection, undo, sourcearea
@bender-ckeditor-plugins: wysiwygarea, toolbar, table, tableselection, undo, sourcearea, elementspath

**Note:** Before you start moving the selected text using D&D, hold down the left mouse button for a moment on selected text.

Expand All @@ -10,9 +10,10 @@

**Expected**

Selected text was moved properly, the content looking good and there is no error in the console.
* Selected text was moved properly.
* The content looking good and there is no error in the console.

**Unxpected**

Selected text was not moved.
There's error in the console.
* Selected text was not moved.
* There's error in the console.

0 comments on commit 06a15c8

Please sign in to comment.