Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CKEDITOR.inlineAll inlining also elements with editor already attached to them #4294

Merged
merged 8 commits into from
Sep 23, 2020

Conversation

Comandeer
Copy link
Member

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

Did you follow the CKEditor 4 code style guide?

Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with the code style guide

What is the proposed changelog entry for this pull request?

* [#4293](https://github.com/ckeditor/ckeditor4/issues/4293): Fixed: [`CKEDITOR.inlineAll`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR.html#method-inlineAll) tries to inline also elements with editor already attached to them.

What changes did you make?

I've just added a simple check if the element has an attached editor, using element#getEditor().

Which issues does your PR resolve?

Closes #4267.
Closes #4293.

@Dumluregn Dumluregn self-requested a review September 22, 2020 09:26
@Dumluregn Dumluregn self-assigned this Sep 22, 2020
Copy link
Contributor

@Dumluregn Dumluregn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

✅ Chrome
✅ Firefox
✅ Safari
✅ Edge
✅ Opera
✅ IE11
✅ IE10
✅ IE9
✅ IE8

I'll do just some minor polishing.

@Dumluregn Dumluregn changed the base branch from master to major September 23, 2020 09:10
@Dumluregn Dumluregn changed the base branch from major to master September 23, 2020 09:11
@Dumluregn Dumluregn merged commit 36dc5ff into master Sep 23, 2020
@Dumluregn Dumluregn deleted the t/4293 branch September 23, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants