Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKEDITOR.inlineAll inlines also already ckeditorized elements #4293

Closed
Comandeer opened this issue Sep 21, 2020 · 1 comment
Closed

CKEDITOR.inlineAll inlines also already ckeditorized elements #4293

Comandeer opened this issue Sep 21, 2020 · 1 comment
Assignees
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@Comandeer
Copy link
Member

Comandeer commented Sep 21, 2020

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open console.
  2. Open https://jsfiddle.net/Comandeer/1yxjt0oL/

Expected result

There are no errors in the console.

Actual result

There is an error in the console:

ckeditor.js:19 [CKEDITOR] Error code: editor-element-conflict. {editorName: "editor"}

Other details

  • CKEditor version: 4.5.0+

It seems that CKEDITOR.inlineAll is fired after CKEDITOR.replace call, trying to inline element with editor already attached to it. Simple check if the element has editor should be enough.

See also #4267, ckeditor/ckeditor4-react#126.

@Comandeer Comandeer added type:bug A bug. status:confirmed An issue confirmed by the development team. core The issue is caused by the editor core code. workload:low labels Sep 21, 2020
@Comandeer Comandeer self-assigned this Sep 21, 2020
@Dumluregn
Copy link
Contributor

Closed in 36dc5ff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants