Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty table cells from the dialog of specialchar plugin #3566

Merged
merged 10 commits into from
Nov 4, 2019
Merged

Remove empty table cells from the dialog of specialchar plugin #3566

merged 10 commits into from
Nov 4, 2019

Commits on Oct 10, 2019

  1. Add role=presentation to empty table cells in dialog of special char … 

    …plugin to avoid bug in screen readers.
    Mateusz Samsel committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    16e6c00 View commit details
    Browse the repository at this point in the history

  2. Add unit test checking role of empty table cells in specialchar dialog.

    Mateusz Samsel committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    cb19bc5 View commit details
    Browse the repository at this point in the history

  3. Remove empty table cells as those was read by narrator and voice over… 

    … anyway.
    Mateusz Samsel committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    8e47d32 View commit details
    Browse the repository at this point in the history

  4. Remove multiple var statements and hoist variable declaration to the … 

    …beginning of scope, to prevent linter errors.
    Mateusz Samsel committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    a11692f View commit details
    Browse the repository at this point in the history

  5. Adapt unit test to check if there is no empty cells in specialchar di… 

    …alog.
    Mateusz Samsel committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    67b19f0 View commit details
    Browse the repository at this point in the history

  6. Add manual test.

    Mateusz Samsel committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    937a136 View commit details
    Browse the repository at this point in the history

  7. Improve template in special char dialog.

    Mateusz Samsel committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    ff05e36 View commit details
    Browse the repository at this point in the history

  8. Improve manual test to better reflect real problem.

    Mateusz Samsel committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    b0c6323 View commit details
    Browse the repository at this point in the history

  9. Correct unit test name

    Mateusz Samsel committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    87031d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. Add changelog entry. [ci skip]

    @Comandeer
    Comandeer committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    c74ad40 View commit details
    Browse the repository at this point in the history