Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty table cells from the dialog of specialchar plugin #3566

Merged
merged 10 commits into from
Nov 4, 2019

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented Oct 10, 2019

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What is the proposed changelog entry for this pull request?

* [#3544(https://github.com/ckeditor/ckeditor4/issues/3544) Fix: Empty table cells at the end of the dialog of [Special Characters](https://ckeditor.com/cke4/addon/specialchar) plugin was read by assistive technologies.

What changes did you make?

  • Remove adding empty table cells in special char dialog.
  • Hoist variables to the top to prevent jshint errors.

Closes: #3544

@Comandeer Comandeer self-requested a review October 31, 2019 13:42
@Comandeer Comandeer self-assigned this Oct 31, 2019
Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Comandeer Comandeer merged commit 42ff73a into master Nov 4, 2019
@CKEditorBot CKEditorBot deleted the t/3544 branch November 4, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants