Skip to content

Commit

Permalink
Builder should automatically pick CKEditor version based on package.j…
Browse files Browse the repository at this point in the history 
…son.
  • Loading branch information
@mlewand
mlewand committed Jul 28, 2017
1 parent aa600bd commit 80493cf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion dev/builder/build.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ echo "Starting CKBuilder..."

JAVA_ARGS=${ARGS// -t / } # Remove -t from args.

VERSION="4.7.2 DEV"
VERSION=`node -pe "require('./package.json').version"`

This comment has been minimized.

Sign in to view

Copy link
@mflorea

mflorea Aug 22, 2017

Contributor

This means that we now need to have Node.js installed in order to build the CKEditor. This is a pain, especially if you build the CKEditor on a Continuous Integration server and you need to ask your infrastructure team to install yet another tool on all the CI agents. I would rather use grep, or perl, or an environment variable, or parse the JSON using Java, rather than adding a dependency on Node.js for such a small thing.

This comment has been minimized.

Sign in to view

Copy link
@mlewand

mlewand Aug 22, 2017

Author Contributor

Good point, we're used to the fact that Node is installed simply everywhere. Using Java or Perl is not a solution here as it's basically the same issue here. Grep seems to be the safest solution - reported in #815 feel free to subscribe/bump it.
VERSION="$VERSION DEV"
REVISION=$(git rev-parse --verify --short HEAD)
SEMVER_REGEX="^([0-9]+)\.([0-9]+)\.([0-9]+)(\-[0-9A-Za-z-]+)?(\+[0-9A-Za-z-]+)?$"

Expand Down

0 comments on commit 80493cf

Please sign in to comment.