Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick CKEditor version from package.json without using node #815

Closed
mlewand opened this issue Aug 22, 2017 · 0 comments · Fixed by #833
Closed

Pick CKEditor version from package.json without using node #815

mlewand opened this issue Aug 22, 2017 · 0 comments · Fixed by #833
Assignees
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:major Any docs related issue that should be merged into a major branch. type:task Any other issue (refactoring, typo fix, etc).
Milestone

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 22, 2017

Are you reporting a feature request or a bug?

Task

Provide detailed reproduction steps (if any)

This means that we now need to have Node.js installed in order to build the CKEditor. This is a pain, especially if you build the CKEditor on a Continuous Integration server and you need to ask your infrastructure team to install yet another tool on all the CI agents. I would rather use grep, or perl, or an environment variable, or parse the JSON using Java, rather than adding a dependency on Node.js for such a small thing.

As noted by our user it would be better if we don't rely on node to pick the version as it adds extra dependency to deal with.

I think that grep would be a nice alternative. Since the script is in bash, we can assume it has the regular linux env binaries around.

Other details

Node-based detection was initially introduced in #572.

@mlewand mlewand added the type:task Any other issue (refactoring, typo fix, etc). label Aug 22, 2017
@mlewand mlewand added this to the Backlog milestone Aug 22, 2017
@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Aug 22, 2017
@wojtekw92 wojtekw92 self-assigned this Aug 28, 2017
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Aug 30, 2017
@f1ames f1ames added target:major Any docs related issue that should be merged into a major branch. and removed target:minor Any docs related issue that can be merged into a master or major branch. labels Sep 18, 2017
@f1ames f1ames modified the milestones: Backlog, 4.8.0 Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:major Any docs related issue that should be merged into a major branch. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants