-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐐
good addition of lots of background info to get people up and running
README.md
Outdated
|
||
## Project Info | ||
|
||
This work began under the he Austin Digital Services Discovery Project. Design, Technology, and Innovation Fellows worked in partnership between two City departments, Communications Public Information and Communications and Technology Management. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
under the he Austin
README.md
Outdated
|
||
### React-Static | ||
|
||
This project uses [React-Static](https://github.com/nozzle/react-static) as a base framework for building static-progressive a React application/website. It's designed to with considerations for SEO, site performance, and user/developer experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for building static-progressive a React application/website
It's designed to with considerations
README.md
Outdated
|
||
This project uses [React-Static](https://github.com/nozzle/react-static) as a base framework for building static-progressive a React application/website. It's designed to with considerations for SEO, site performance, and user/developer experience. | ||
|
||
TODO: more on this decision + evaluation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meh
README.md
Outdated
|
||
## Design assets | ||
Since we use React-Static as our framework to render our React components as a static progressive website, its important for us to be able to test the final static build locally. In order to do this, we have two scripts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its important
README.md
Outdated
|
||
--- | ||
**To build and server** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean 'To Build and Serve' (no r)
Also I'm not sure we would ever run build.sh by itself -- but maybe we would?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, we made the build script before the build and serve and I haven't used it since.
Do we want to invest in making our serve-local build operable in IE so we can live debug in IE? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ifsimicoded thanks for detail around how we would make serve-local work in IE. If its as easy as downgrading a dependency, I'd say why not give it a try and log it as an issue. But when it comes to live debugging in IE, wouldn't it be better to use |
Closes cityofaustin/techstack#146
Closes https://github.com/cityofaustin/coa-dev-internal/issues/21
Starts cityofaustin/techstack#308
There is definitely more comprehensive work we could be doing but I'm hesitant to over commit us this early in the project and without a dedicated QA resource. I really like this guideline cfpb has: https://github.com/cfpb/development/blob/master/guides/browser-support.md
Logged some more issues as a result of browsing that can be addressed in another PR.