Pull in Upstream Changes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoupdate pre-commit hooks. Add mypy.
…ignore Add .mypy_cache to .gitignore
This should resolve the issue seen when the Python version changes before there is an update to .pre-commit-config.yml which results in pre-commit pointing to a non-existent Python installation.
Incorporate the Python version into keys for pip and pre-commit caches.
…cks to environment variables declared before the job block.
Change Cache Paths to Environment Variables
…ame as long as they are not nested in the same heading group.
Add markdownlint Configuration Option for MD024
terraform_validate_no_variables was changed to terraform_validate in the following commit: antonbabenko/pre-commit-terraform@35e0356. Ran pre-commit autoupdate.
Update pre-commit Hooks and Fix Broken Hook ID
…provements/upstream_updates
Add Terraform initialization to the GitHub Actions workflow.
…validate hook to work with our directory tree.
jsf9k
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
Very nice work, @mcdonnnj! I am following antonbabenko/pre-commit-terraform#100.
I made one suggestion, which you can take or leave.
main.tf
Outdated
| @@ -7,6 +7,11 @@ | |||
| # The AWS account ID being used | |||
| data "aws_caller_identity" "current" {} | |||
|
|
|||
| # Default provider information. | |||
There was a problem hiding this comment.
I suggest moving this provider block above the aws_caller_identity, or to a separate file called providers.tf. No big deal if you disagree.
There was a problem hiding this comment.
Forgot to mention that I fixed this in 0176807 by moving it to providers.tf. Thanks for the feedback!
…nto the providers.tf per excellent feedback.
…iminate changing directories.
… runs. +Add directive to find and initialize Terraform directories. -Removed directive that searched for Terraform directories.
… has been merged.
`pre-commit-terraform` hook since the PR I submitted, antonbabenko/pre-commit-terraform#100, was approved. This will fix issues with `skeleton-tf-module` related to multiple directories with Terraform code.
…hen the failure is with setup rather than hooks running.
…lding. Adjust description for pre-commit hook setup to better convey what is being done.
…commit-terraform_hook Update pre-commit Hooks to Include Bugfix
…provements/upstream_updates
dav3r
approved these changes
Apr 7, 2020
jsf9k
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR pulls in the changes in cisagov/skeleton-generic#40 (and a bit more from before).
💭 Motivation and Context
Keep it up to date!
🧪 Testing
pre-commitruns without issue.📷 Screenshots (if appropriate)
🚥 Types of Changes
✅ Checklist