Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit Hooks and Fix Broken Hook ID #40

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This is just a maintenance PR with a splash of bugfix. I'd like to update pre-commit on a monthly schedule to keep things from getting too stale. This is the first PR with that in mind.

I also noticed that there was a problem with the terraform_validate_no_variables hook from the pre-commit-terraform repo. Upon investigation I found that the hook id had been changed in antonbabenko/pre-commit-terraform@35e0356 and the hook id used here had never been updated to follow. The -check-variables switch used to differentiate the two previous terraform_validate hooks no longer appears to be an option for the terraform validate command per the Terraform documentation.

💭 Motivation and Context

Being up-to-date is good. Getting a regular cadence of being up-to-date is even better.

🧪 Testing

pre-commit hooks worked as expected.

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

  terraform_validate_no_variables was changed to terraform_validate in the
  following commit:
  antonbabenko/pre-commit-terraform@35e0356.
Ran pre-commit autoupdate.
@mcdonnnj mcdonnnj requested review from dav3r, felddy, jsf9k and a team as code owners March 31, 2020 19:17
@mcdonnnj mcdonnnj self-assigned this Mar 31, 2020
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💎
Good catch on the terraform_validate business.

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch, sir! ⚾ 🥊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants