-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Integration of skeleton-generic #302
Conversation
Rename repo to skeleton-generic
Remove author information from README
In particular, mention pyenv-installer.
Update the pyenv installation instructions
They are not needed there. Also run pre-commit autoupdate to pick up the latest version of hooks.
…_docker_compose Add pre-commit hook for docker-compose linting
Also ran pre-commit autoupdate, which picked up a newer version of the pyupgrade hook.
Add bandit pre-commit hook
This is a warning about line breaks before binary operators. It no longer agrees with PEP8. See, for example, here: psf/black#21. Guido agrees here: python/peps@c59c437.
Ignore W503 from flake8
Also add flake8-docstrings as an additional dependency in the .pre-commit-config.yml file.
Add pydoc warnings to flake8 config
Improvement bandit config
Also update the URL for black since it moved GitHub orgs from ambv to python.
Run pre-commit autoupdate
…ss_yamllint Make .bandit.yml pass yamllint
This should speed up TravisCI builds.
Via pre-commit autoupdate.
Use TravisCI caching to speed up builds
Add changes from running pre-commit autoupdate
There is no need to run python code to determine the python version. Resolves #58. See here for details: https://github.com/actions/setup-python/blob/main/action.yml#L14-L16
Group related pre-commit hooks together. Make sure that hooks are alphabetically sorted within those groups.
Organize and Sort pre-commit Hooks
…gihub-dir Ensure that the cisagov devs are the owners of the .github directory
…re-simply Use the python version output by actions/setup-python
Removed name because it was not more informative than the default. Swapped out a hardcoded job reference for the github.job context value. Switch the base cache key to a step environment value so we can set it once and reuse. Removed additional restore-key value that might have undesirable results.
Improve actions/cache Configuration
Comment out all hooks that haven't been run and resolved yet. This leaves only the hooks used in #295 enabled for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks for dragging this 900 pound gorilla into the light!
I had one question, but I am happy to approve this no matter the answer.
*.tfvars | ||
*.dyn.tf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the *.dyn.tf
line for the code generated in the terraform/dyn_*
directories? I'm not sure, so I'm asking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's a good question. We probably do and I just got overzealous with .gitignore
cleaning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have restored that pattern in 22c028b
I was overzealous and removed the *.dyn.tf pattern from this repository's .gitignore file. Since our Terraform configuration uses modules, this is still a necessary pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💀
🗣 Description
This PR is an initial integration of cisagov/skeleton-generic.
💭 Motivation and Context
I'm moving forward with working on #301 , and this gets the framework for everything in place to work on passing each
pre-commit
hook group and merging those in their own PRs.🧪 Testing
The GitHub Actions workflow is passing with the pared down
pre-commit
configuration to align with the progress made in #295 .✅ Checklist