Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate cisagov/skeleton-generic Into This Repository #301

Open
6 of 10 tasks
mcdonnnj opened this issue Dec 17, 2020 · 0 comments
Open
6 of 10 tasks

Integrate cisagov/skeleton-generic Into This Repository #301

mcdonnnj opened this issue Dec 17, 2020 · 0 comments
Assignees
@mcdonnnj
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@mcdonnnj
Copy link
Member

mcdonnnj commented Dec 17, 2020 •
edited
Loading

🚀 Feature Proposal

Skeletonize this repository by integrating cisagov/skeleton-generic into this repository.

Motivation

Since this is one of our active projects, it should descend from a skeleton repository. Given the monolithic nature of this repository, I think that cisagov/skeleton-generic is the best choice (for now at least). This will get our linting setup installed and help with this repository's health.

However, given the status of the project, I think it needs to be done incrementally. I already let our pre-commit configuration run against Terraform code in #295 , but we will need to get each other group of hooks passing in turn. Since I broke them up by category in cisagov/skeleton-generic#60, I think they should be enabled in PRs by type of file.

Here is a checklist to track progress:

  • Base pre-commit-hooks
  • Text file hooks (broken up because of the large work between markdownlint and yamllint)
    • markdownlint
    • prettier
    • yamllint
  • Shell script hooks
  • Python hooks
  • Ansible hooks
  • Terraform hooks
  • Docker hooks
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Dec 17, 2020
@mcdonnnj mcdonnnj self-assigned this Dec 17, 2020
@mcdonnnj mcdonnnj mentioned this issue Dec 17, 2020
Merged
8 tasks
@mcdonnnj mcdonnnj mentioned this issue Dec 29, 2020
Open
7 tasks
@mcdonnnj mcdonnnj mentioned this issue Feb 11, 2022
Closed
@mcdonnnj mcdonnnj mentioned this issue Jul 21, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcdonnnj