Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timing bug workaround for node.js 0.11 / io.js 1.1.0 #241

Closed
wants to merge 1 commit into from
Closed

Timing bug workaround for node.js 0.11 / io.js 1.1.0 #241

wants to merge 1 commit into from

Commits on Feb 4, 2015

  1. Timing bug workaround for node.js 0.11 / io.js 1.1.0 

    In connection with nodejs/node#712 (comment) I've found that wrapping this method solves a timing bug that appears to be deep in the bowels of node (or perhaps it is somewhere in oauth2).

I can faithfully reproduce the bug, but haven't been able to isolate it outside of passport / oauth2 (probably due to the nature of the timing and the number of callbacks).

node v0.10.35 does not manifest the error.
    AJ ONeal committed Feb 4, 2015
    Configuration menu
    Copy the full SHA
    8eae327 View commit details
    Browse the repository at this point in the history