Timing bug workaround for node.js 0.11 / io.js 1.1.0 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In connection with nodejs/node#712 (comment) I've found that wrapping this method solves a timing bug that appears to be deep in the bowels of node (or perhaps it is somewhere in oauth2). I can faithfully reproduce the bug, but haven't been able to isolate it outside of passport / oauth2 (probably due to the nature of the timing and the number of callbacks). node v0.10.35 does not manifest the error.
|
Ugggh :( and so it begins! (Io vs node) thank you :) |
|
The bug was found! This should be fixed in io.js v1.1.1, but who knows when that will get merged into node v0.11 |
|
I haven't tested in node v0.12, but this was definitely fixed in io.js v1.2 closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In connection with nodejs/node#712 (comment) I've found that wrapping this method solves a timing bug that appears to be deep in the bowels of node (or perhaps it is somewhere in oauth2, but seeing that it comes from C code, I don't think that's the case).
I can faithfully reproduce the bug, but haven't been able to isolate it outside of passport / oauth2 (probably due to the nature of the timing and the number of callbacks).
node v0.10.35 does not manifest the error.