Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteValue - add type param #5

Closed
wants to merge 1 commit into from
Closed

WriteValue - add type param #5

wants to merge 1 commit into from

Conversation

buildog
Copy link

@buildog buildog commented Jun 8, 2020 •
edited
Loading

According to Bluez API (https://github.com/hadess/bluez/blob/master/doc/gatt-api.txt) you can specify the write type (eg: Write without response)

This PR aim to add this type parameter to WriteValue

Here is the allowed types :

"command": Write without response
"request": Write with response
"reliable": Reliable Write

@buildog buildog changed the title WriteValue - add type paramerter WriteValue - add type param Jun 8, 2020
@chrvadala chrvadala self-assigned this Jun 13, 2020
@chrvadala
Copy link
Owner

Thank you for your PR. Can you provide a test suite for that?

@chrvadala chrvadala self-requested a review June 20, 2020 16:22
chrvadala
chrvadala requested changes Jun 20, 2020
View reviewed changes
Copy link
Owner

@chrvadala chrvadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for unit test

@chrvadala chrvadala closed this Dec 19, 2020
@chrvadala chrvadala deleted the branch chrvadala:master December 19, 2020 21:01
@lupol lupol mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrvadala chrvadala chrvadala requested changes

Assignees

@chrvadala chrvadala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buildog @chrvadala