Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writeValue - options improvements #20

Merged
merged 3 commits into from
Jan 24, 2021
Merged

writeValue - options improvements #20

merged 3 commits into from
Jan 24, 2021

Conversation

lupol
Copy link
Contributor

@lupol lupol commented Jan 12, 2021

I saw closed PR with changes related to my current problem.

I faced an issue while using type reliable for writeValue. I update a little bit options for this method, all changes according to Bluez Gatt-Api

@coveralls
Copy link

coveralls commented Jan 12, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 95.833% when pulling bf35881 on lupol:writeValueOptionsTypes into 89506bf on chrvadala:main.

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

chrvadala
chrvadala requested changes Jan 17, 2021
View reviewed changes
Copy link
Owner

@chrvadala chrvadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for your PR. I added some comments inline.

src/GattCharacteristic.js Outdated Show resolved Hide resolved
test/GattCharacteristic.spec.js Outdated Show resolved Hide resolved
@chrvadala chrvadala added the enhancement New feature or request label Jan 17, 2021
@lupol lupol requested a review from chrvadala January 20, 2021 10:00
@chrvadala chrvadala merged commit 9879cfa into chrvadala:main Jan 24, 2021
@chrvadala
Copy link
Owner

Released with v1.5.0
Thanks for your PR

@lupol lupol deleted the writeValueOptionsTypes branch January 25, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrvadala chrvadala chrvadala approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lupol @coveralls @chrvadala