Creating addons section #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zol
reviewed
May 16, 2019
|
@ndelangen @zol is this still active? |
|
@domyen to the best of my knowledge, this was/is blocked on the 5.2 release, @ndelangen is that correct? |
|
correct, we need 5.2 to be released, which has the new hooks apis in it. |
zol
reviewed
Sep 21, 2019
Closed
IMPROVE mention current config path ADD section about addons.js
|
@zol WDYT, mergeable? |
|
@ndelangen It's almost good to go from my end, just need a better screenshot as per my remaining outstanding comment |
|
@zol WDYT? |
|
Bit more stylised: |
# Conflicts: # content/intro-to-storybook/react/en/addons.md # content/intro-to-storybook/react/pt/addons.md # content/react/en/addons.md # content/react/en/using-addons.md # content/react/pt/addons.md # content/react/pt/using-addons.md # gatsby-config.js
|
@zol WDYT? |
|
Looks great @ndelangen . I'm ready to have this merged and shipped! |
|
@domyen merge when ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a section to the guide on how to write addons