Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of quick questions #138

Closed
jonniebigodes opened this issue Sep 22, 2019 · 5 comments
Closed

A couple of quick questions #138

jonniebigodes opened this issue Sep 22, 2019 · 5 comments

Comments

@jonniebigodes
Copy link
Collaborator

This one has been on the back burner for quite some time and sorry for that.
Here are the questions:

  • While i was working in translating the documentation, one thing kept me wondering and that was about the addons section, react has it but vue and angular doesn't, is this section left out by omission, probably due to the fact that probably no one made a pr for it? Should it be a good thing to revisit this and try and standardize the whole documentation? More even now that Creating addons section #91 is currently underway.

  • I was thinking about having a copy code snippet button added to the documentation, is this doable in a near future? After the refresh of the site is gone through and possibly expand it to Review Design Systems for Developers guide #137.

Feel free to provide feedback

Thanks in advance

@domyen
Copy link
Member

domyen commented Sep 23, 2019

Great questions.

  • Omission wasn't intentional. We're definitely looking for help to translate those sections and for more help in Vue and Angular (both for this guide and in Storybook itself).
  • Good idea. Would totally welcome a PR that adds a copy button to the syntax highlight.

I know we have a syntax highlighter component in the Storybook Design System (which this project uses), but I think there was a hiccup integrating it for some reason. cc @kylesuss

@kylesuss
Copy link
Contributor

@jonniebigodes I think a safe approach would be to add the feature to the Highlight component in the design system. The end goal is to have that component be apart of the design system & able to be used in any client application. There was just a difference in how some of the clients implemented it, so I couldn't actually import that component into all of the client apps yet. It wasn't as big of an issue for learnstorybook.com though.

In the PR for the new layout, I am importing the Highlight component into learnstorybook.com:

import { Highlight, styles } from '@storybook/design-system';

If you add the logic in the Highlight component in the design system, it should be accessible in the new layout work for learnstorybook.com once a new release of the design system is shipped.

Sound ok?

@jonniebigodes
Copy link
Collaborator Author

jonniebigodes commented Sep 25, 2019

@kylesuss sounds excelent. Once again, you've been doing a really awesome job with this implementation.

@domyen regarding the code in this repo for vue i'm currently testing some things out and i'm going to create a issue and we can go over it afterwards. Sounds good?

Also as a side note that i forgot to ask when i commented out in #137 and if you can share some insights on it. Do you plan to release it like in this repo and do you want translations for it?

In the meantime i'll close this issue as technically is answered.

@domyen
Copy link
Member

domyen commented Sep 28, 2019

@jonniebigodes We plan to release the guide as part of LearnStorybook! Would love and appreciate translations! 🙇‍♂️

@jonniebigodes
Copy link
Collaborator Author

@domyen ok...i've been checking the commits being made to the next branch. As soon as it's relased i'll start working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants