Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore updates for storybook 6 2 #482

Merged
merged 14 commits into from
Apr 27, 2021
Merged

Conversation

jonniebigodes
Copy link
Collaborator

With this pull request, the Intro to Storybook tutorial is updated to Storybook 6.2
What was done:

  • The React, Angular, Svelte, Vue, Ember versions of the tutorial were updated to Storybook 6.2
  • Some of the videos and images related to the tutorial were updated for 6.2
  • The Simple component chapter, more specifically the Unit testing section, was updated to include a reference to the Testing library as opposed to Jest, just to clarify the context.
  • The Vue version was updated to Vue 3
  • The gatsby-config.js configuration object was updated to 6.2

Closes:

Addresses:

With this I would like to ask:

Feel free to provide feedback

FabrizioRizzi added a commit to FabrizioRizzi/learnstorybook.com that referenced this pull request Apr 27, 2021
Despite chromaui#482, there is still an unnecessary curly bracket ;-)
@jonniebigodes
Copy link
Collaborator Author

Self merging this

@jonniebigodes jonniebigodes merged commit c53f524 into master Apr 27, 2021
@jonniebigodes jonniebigodes deleted the chore_updates_for_storybook_6_2 branch April 27, 2021 20:58
@jeanphi-baconnais
Copy link

Hi @jonniebigodes , for the french vue translatation, do you prefer i create a new PR or i continue on this existing one https://github.com/chromaui/learnstorybook.com/pull/434/commits

@jonniebigodes
Copy link
Collaborator Author

@jeanphibaconnais you can continue on your pull request. Fine by me, as you have already the bulk of the work done. In terms of changes for the Vue edition, it's only the snippets that require a bit of work and also some minor wording changes here and there. But if you want to open a fresh pull request I'm good with it as well. I'll let you decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants