Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in intro-to-storybook testing docs #464

Closed
wants to merge 1 commit into from

Conversation

TheMightyPenguin
Copy link

@TheMightyPenguin TheMightyPenguin commented Mar 20, 2021

Not sure if this was a typo or intended, but visual was twice in the list, so I think this was meant to say "manual" instead

@jonniebigodes
Copy link
Collaborator

@TheMightyPenguin it's not a typo, thanks for catching this! Do you mind updating the other versions as well?

If so, one thing to look out for. In the Ember version, remove the snapshot, as we're not documenting @storybook/addon-storyshots usage the same as the other ones.

Let me know when you took care of it and I'll gladly merge this.

Stay safe

@jonniebigodes
Copy link
Collaborator

@TheMightyPenguin I've pushed a pull request (#482) with the changes you're introducing already in here. I covered all of the frameworks accordingly to clarify the misconception introduced.

Feel free to open a new issue or pull request if you encounter a problem with the tutorials.

Stay safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants